Closed Gaojianli closed 2 months ago
The modifications involve updating the Dockerfile to use a new Maven base image for the build stage, refining the build setup, and switching to a newer Ubuntu JRE image for the runtime environment. Additionally, a script adjustment ensures commands execute in the correct directory for the WebUI setup.
File(s) | Change Summary |
---|---|
Dockerfile |
Updated base images for build and runtime stages, added build setup commands, revised environment settings, volume configuration, and entrypoint. |
setup-webui.sh |
Modified script to change directory before executing commands to ensure correct directory context. |
🐇💻✨ A hop, a skip, in the code we dip, To the Dockerfile, a crafty flip, Maven sails on new version trips, WebUI dances, no missteps or slips. Cheers to the bits, all neatly equipped! 🎉
setup-webui.sh (4)
[warning] 3-3: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. --- [info] 3-3: Double quote to prevent globbing and word splitting. --- [warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. --- [info] 7-7: Double quote to prevent globbing and word splitting.
Dockerfile (4)
`1-1`: Update to a new Maven base image for the build stage is noted. --- `3-5`: Ensure the build process is correctly set up in the Docker environment. --- `7-7`: Switch to a smaller JRE base image for the final stage is noted. --- `8-15`: Review and verify the new environment settings, volume configurations, and entrypoint. Ensure that the new settings align with operational requirements and that the entrypoint correctly initializes the application.
Please suqash and merge it
To ensure the image reproducible, the dockerfile shouldn't rely on any external binary, this PR build the .jar in the docker, and then pack it with a smaller jre, which size is only just a half of the current one.
This image has been tested
Summary by CodeRabbit