PBH-BTN / PeerBanHelper

自动封禁不受欢迎、吸血和异常的 BT 客户端,并支持自定义规则。PeerId黑名单/UserAgent黑名单/IP CIDR/假进度/超量下载/进度回退/多播追猎/连锁封禁/伪装检测 支持 qBittorrent/Transmission/Deluge/BiglyBT
GNU General Public License v3.0
550 stars 16 forks source link

Use 2-stage Dockerfile to ensure image reproducible #96

Closed Gaojianli closed 2 months ago

Gaojianli commented 2 months ago

To ensure the image reproducible, the dockerfile shouldn't rely on any external binary, this PR build the .jar in the docker, and then pack it with a smaller jre, which size is only just a half of the current one.

image

This image has been tested

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The modifications involve updating the Dockerfile to use a new Maven base image for the build stage, refining the build setup, and switching to a newer Ubuntu JRE image for the runtime environment. Additionally, a script adjustment ensures commands execute in the correct directory for the WebUI setup.

Changes

File(s) Change Summary
Dockerfile Updated base images for build and runtime stages, added build setup commands, revised environment settings, volume configuration, and entrypoint.
setup-webui.sh Modified script to change directory before executing commands to ensure correct directory context.

🐇💻✨ A hop, a skip, in the code we dip, To the Dockerfile, a crafty flip, Maven sails on new version trips, WebUI dances, no missteps or slips. Cheers to the bits, all neatly equipped! 🎉


Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between a65714631aaa7c34599796458c7a5ff9beaadf42 and 176a55895940c899c70f8176f04d638c3c870ae5.
Files selected for processing (2) * Dockerfile (1 hunks) * setup-webui.sh (1 hunks)
Additional Context Used
ShellCheck (4)
setup-webui.sh (4)
[warning] 3-3: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. --- [info] 3-3: Double quote to prevent globbing and word splitting. --- [warning] 7-7: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. --- [info] 7-7: Double quote to prevent globbing and word splitting.
Additional comments not posted (4)
Dockerfile (4)
`1-1`: Update to a new Maven base image for the build stage is noted. --- `3-5`: Ensure the build process is correctly set up in the Docker environment. --- `7-7`: Switch to a smaller JRE base image for the final stage is noted. --- `8-15`: Review and verify the new environment settings, volume configurations, and entrypoint. Ensure that the new settings align with operational requirements and that the entrypoint correctly initializes the application.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Gaojianli commented 2 months ago

Please suqash and merge it