Closed erikyuzwa closed 11 years ago
I think we purposely removed references to components that are not used in the bare bones demo. Do you think it would be useful to include all possible components in the default config.JSON?
The number of components is pretty large. I would recommend including them as a commented-out list if we do include them.
This particular component is referenced by hero.json, but hero.json doesn't use it for anything any more. So it should be removed from hero.json, not added here. (unless we want to add everything?)
@Scott, I understand but this reference was getting called ( by hero.json as pointed out by Derek)
@Derek, definitely I'd opt for removing whatever isn't necessary. My bad, I should've gone through hero then to double check that angle.
On Nov 5, 2013, at 9:05 AM, Derek Detweiler notifications@github.com wrote:
The number of components is pretty large. I would recommend including them as a commented-out list if we do include them.
This particular component is referenced by hero.json, but hero.json doesn't use it for anything any more. So it should be removed from hero.json, not added here. (unless we want to add everything?)
— Reply to this email directly or view it on GitHub.
I removed the hero.json reference. Regarding the full list of components, I'm thinking we could change the wiki so that there is a single page dedicated just to listing available engine components and maybe have a comment in the example config that points to that page.
Good idea on the component list! We need a space for people to share new components they make as well and that could serve that purpose.
I like that as well, good stuff @probityrules.
missing reference to logic-portable component