search

PBug90 / w3gPlus

A new standard for Warcraft 3 Replays.
3 stars 1 forks source link

Jass library review + issues #1

Open Luashine opened 2 years ago

Luashine commented 2 years ago

w3gpluss.vjass:

  1. No 24-player support L42 and L71
  2. Edge case & future-proofing: RACE_DEMON and RACE_OTHER are not checked, there's no else "unknown" catch-all branch - L73

For common.j:

    constant race               RACE_HUMAN                      = ConvertRace(1)
    constant race               RACE_ORC                        = ConvertRace(2)
    constant race               RACE_UNDEAD                     = ConvertRace(3)
    constant race               RACE_NIGHTELF                   = ConvertRace(4)
    constant race               RACE_DEMON                      = ConvertRace(5)
    constant race               RACE_OTHER                      = ConvertRace(7)

MapMetaDataLibrary.vjass

  1. No 24-player support: L209, L322, L364, L459,

For max player count use: https://lep.duckdns.org/app/jassbot/doc/GetBJMaxPlayers

I hope this is still used and I didn't just waste a bunch of time :)

PBug90 commented 2 years ago

This is currently not used, but if you are interested in updating it you can provide a PR to fix the issues you mentioned.