PButcher / flipdown

⏰ A lightweight and performant flip styled countdown clock
https://pbutcher.uk/flipdown/
MIT License
384 stars 123 forks source link

IE support #15

Open renerpdev opened 4 years ago

renerpdev commented 4 years ago

Recently i tried to display my site in IE and I noticed that flipdown did not work, please update the code so we can use it on this browser. Thanks

note: It seems there is a problem when loading ES format. flipdown error with ES

PButcher commented 4 years ago

Which version of IE were you trying this in please?

renerpdev commented 4 years ago

IE version 11.

On Thu, Oct 17, 2019 at 6:22 AM Peter Butcher notifications@github.com wrote:

Which version of IE were you trying this in please?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PButcher/flipdown/issues/15?email_source=notifications&email_token=AHWPQVZVWLXUKZ4DZLTDSUTQPA4ETA5CNFSM4I4YQH72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBPTCRA#issuecomment-543109444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWPQVZEUOXGQ225BPDA43DQPA4ETANCNFSM4I4YQH7Q .

mbdmt commented 4 years ago

main.js line 1,13,18 find all "() => " change to "function()" can support IE11

ribeiroeder commented 4 years ago

Hello @mbdmt

I changed the lines mentioned, but in IE11 here nothing appears

https://ederribeiro.com.br/test-counter/flip/

mbdmt commented 4 years ago

Hello @mbdmt

I changed the lines mentioned, but in IE11 here nothing appears

https://ederribeiro.com.br/test-counter/flip/

you can try path /src change to /dist https://cdn.jsdelivr.net/npm/flipdown@0.3.2/dist/flipdown.min.js

ribeiroeder commented 4 years ago

Great! Now running on IE! thank you

genew commented 4 years ago

FYI - visited https://ederribeiro.com.br/test-counter/flip/ and when resize browser to minimal width, numbers are not displayed correctly. IE and Chrome both look wrong so not a browser issue.

ribeiroeder commented 4 years ago

Hello @genew thanks!

I appreciate the observation, it was missing a comma in the stylesheet that I must have removed by accident.