search

PC-Logix / OpenFM

Streaming radio mod for Minecraft, with OpenComputers control support
MIT License
25 stars 17 forks source link

Crash when I try to tune to a radio with unsupported codec #45

Open vico93 opened 8 years ago

vico93 commented 8 years ago

Using OpenFM-1.9.4-0.1.0.9 and Forge 1.10.2-12.18.1.2026.

When i try to tune an AAC stream from Shoutcast (specifically this one) Minecraft simply freeze, and if on fullscreen mode (my case) the screen became black (even CTRL+Alt+Del doesn't switch the focus of the MC window) and i need to forcefully terminate the java process locking the screen (to release the screen), going to Task Manager and terminating the process. I don't get any logs (i think because of the forceful termination).

Yeah, i know OpenFM still doesn't support AAC (I've requested this separately in #46 ), but a failsafe method to detect an unsupported codec (and throw an error like "Invalid stream encoder!" instead of hangup) would be better.

CaitlynMainer commented 8 years ago

One of two things is happening here, either that station is killing the request builder by responding with trash headers, or its lying about it's file type.

https://git.io/vK70X I handle ONLY MP3 and OGG anything else is ignored and dropped. I'll look into this when I have time though

vico93 commented 8 years ago

Checked on Winamp; the filetype they are presenting are audio/aacp

image