search

PC-Logix / OpenFM

Streaming radio mod for Minecraft, with OpenComputers control support
MIT License
25 stars 17 forks source link

If the stream is invalid, the client hangs until long after it disconnects from the server #53

Open gdude2002 opened 7 years ago

gdude2002 commented 7 years ago

MC: 1.10.2 Forge: 12.18.3.2185 OFM: 0.1.0.18

Pretty much as the title says. It's making it impossible to login to my server as there's a misconfigured radio at spawn.

gdude2002 commented 7 years ago

For a little more context, we downloaded a .pls file like this.

[playlist]
NumberOfEntries=1

File1=http://31.14.40.241:9766

That URL actually points to a webpage instead of the stream URL. My client had been frozen for 5+ minutes, so I'm restarting with streams disabled in the config so I can turn off this radio

CaitlynMainer commented 7 years ago

Putting the URL: http://31.14.40.241:9766 Directly into my player plays fine. I'd like to point out though that their site links to the AAC playlist when clicking the MP3 link.. which made for lots of fun trying to debug. Since OpenFM has a half functioning AAC decoder implemented (That caused EXACTLY the same issues you described here)

CaitlynMainer commented 7 years ago

Turns out they have the links backwards... the AAC playlist links to the MP3 stream, and the MP3 playlist links to the AAC stream.

P.S. http://www.christmasfm.com/streams/xmasfm64aac.pls Plays fine for me, since it plays the MP3 stream.

gdude2002 commented 7 years ago

Wasn't aware you could just stick the pls files into it.

Hang is pretty bad either way though, is there any chance of some kind of scheduler?

CaitlynMainer commented 7 years ago

The hang was because it was activating the broken AAC decoder.. which is broken... which should not have happened as it's broken and was supposed to be disabled. And will be in the next build.

gdude2002 commented 7 years ago

Gotcha, thanks.