search

PC-Logix / OpenSecurity

Security addon for OpenComputers
MIT License
46 stars 24 forks source link

Turret orientation input in Radians #55

Closed MajorGeneralRelativity closed 8 years ago

MajorGeneralRelativity commented 8 years ago

Have either another method, or convert the current one to allow the inputting of Energy turret angle in Radians, because Radians are the way mathematicians do it, and the math.asin, math.acos, etc. output in radians. Degrees * 180 / (pi) = radians

gamax92 commented 8 years ago

math.deg is a thing, it converts radians into degrees.

MajorGeneralRelativity commented 8 years ago

I know, but I wanted to avoid the overhead of calling it

SuPeRMiNoR2 commented 8 years ago

If it was added to the mod, the mod would probably have to do the same conversion. So there really is no point.

MajorGeneralRelativity commented 8 years ago

I would like it, and radians are the more mathematical thing to do. Mimiru said to create an issue for it, so I did. If it doesn't happen, it doesn't.

SuPeRMiNoR2 commented 8 years ago

Oh, sorry. In that case, I guess it will get added eventually XD

MajorGeneralRelativity commented 8 years ago

@SuPeRMiNoR2 you don't need to apologize. Your concerns are just as valid as my wishes :)

CaitlynMainer commented 8 years ago

Please test the latest dev build 47 and see if this works the way you'd like

CaitlynMainer commented 8 years ago

http://ci.pc-logix.com/job/OpenSecurity-Dev/