search

PCCMathSAC / apex-mbx

Repository for a conversion of APEX Calculus to MathBook XML
2 stars 10 forks source link

Minor tweaks to language and units #27

Closed CVollet closed 8 years ago

Alex-Jordan commented 8 years ago

Looks good. Don't worry about formatting units much, but if they are altogether absent and you feel they should be there, put something in. Ultimately units will all be handled with the <quantity> element, both in and out of math. But right now, in math, it's not implemented.

I don't agree with the new question mark at line 681 unless the sentence is reworded to start like "This leads us to wonder, what is the limit..." Is that agreeable to you? If so, let's do a git exercise. Edit this line locally on the same branch (dev), then commit the edit, then push to CVollet. And just like that, this pull request will include the second commit as well.

CVollet commented 8 years ago

Ok, I think I did it right. I see my second comment there now.