search

PCCMathSAC / apex-mbx

Repository for a conversion of APEX Calculus to MathBook XML
2 stars 10 forks source link

added ids for more images in sidebysides #35

Closed davidfarmer closed 8 years ago

davidfarmer commented 8 years ago

Added xml:id's for 109 images in sidebyside's.

Adding more imade id's will be possible once I understand how to fix a couple of markup issues. (See my email from earlier today).

Alex-Jordan commented 8 years ago

I'm getting a lot of error messages like:

/Users/alex.jordan/apex-mbx/src/sec_param_eqs.mbx:1164: element image: validity error : ID img_09_02_ex_05 already defined
              <image xml:id="img_09_02_ex_05" >
davidfarmer commented 8 years ago

How about I run a new script over everything, and start adding a, b, c, .... to the end of non-unique images?

I think that would be okay in this case, because the image id's are generally not meaningful (the one you cited, for example).

On Fri, 9 Sep 2016, Alex Jordan wrote:

I'm getting a lot of error messages like:

/Users/alex.jordan/apex-mbx/src/sec_parameqs.mbx:1164: element image: validity error : ID img 09_02_ex_05 already defined

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LAwb9l3G9tzSGHAi344ax77xRPquks5qoiFCgaJpZM4J5GJ6.gif]
Alex-Jordan commented 8 years ago

OK, I verified these are all duplicate ids in image elements just to check something hadn't accidentally gone wrong with figures, etc. Are you saying you believe the duplication comes from when a figure or sidebyside had multiple images inside, and the figure or sidebyside's id was recycled more than once onto an img_? If you believe that is where these are all coming from, then your plan sounds good.

On Sat, Sep 10, 2016 at 4:27 AM, davidfarmer notifications@github.com wrote:

How about I run a new script over everything, and start adding a, b, c, .... to the end of non-unique images?

I think that would be okay in this case, because the image id's are generally not meaningful (the one you cited, for example).

On Fri, 9 Sep 2016, Alex Jordan wrote:

I'm getting a lot of error messages like:

/Users/alex.jordan/apex-mbx/src/sec_parameqs.mbx:1164: element image: validity error : ID img 09_02_ex_05 already defined

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LAwb9l3G9tzSGHAi344ax77xRPquks5qoiFCgaJpZM4J5GJ6.gif]

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/35#issuecomment-246106790, or mute the thread https://github.com/notifications/unsubscribe-auth/AEg3AG22i0-IzhNdc-Aeh-jZsuieCMepks5qopQOgaJpZM4J5GJ6 .

Alex Jordan Mathematics Instructor Portland Community College

davidfarmer commented 8 years ago

This is the problem: there is an exercise which contains both an answer and a solution. Both refer to an image, which come from the same file, of course. We have been using the original filename to make the image id, so of course those are duplicated for now.

Probably all the repeats are in pairs, so I will add "X" to the end of the second id.

New pull request soon.

On Fri, 9 Sep 2016, Alex Jordan wrote:

I'm getting a lot of error messages like:

/Users/alex.jordan/apex-mbx/src/sec_parameqs.mbx:1164: element image: validity error : ID img 09_02_ex_05 already defined

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LAwb9l3G9tzSGHAi344ax77xRPquks5qoiFCgaJpZM4J5GJ6.gif]
davidfarmer commented 8 years ago

Replaced by new pull request.

davidfarmer commented 8 years ago

I closed this pull request and submitted another which should be okay.

On Sat, 10 Sep 2016, Alex Jordan wrote:

OK, I verified these are all duplicate ids in image elements just to check something hadn't accidentally gone wrong with figures, etc. Are you saying you believe the duplication comes from when a figure or sidebyside had multiple images inside, and the figure or sidebyside's id was recycled more than once onto an img_? If you believe that is where these are all coming from, then your plan sounds good.

On Sat, Sep 10, 2016 at 4:27 AM, davidfarmer notifications@github.com wrote:

How about I run a new script over everything, and start adding a, b, c, .... to the end of non-unique images?

I think that would be okay in this case, because the image id's are generally not meaningful (the one you cited, for example).

On Fri, 9 Sep 2016, Alex Jordan wrote:

I'm getting a lot of error messages like:

/Users/alex.jordan/apex-mbx/src/sec_parameqs.mbx:1164: element image: validity error : ID img 09_02_ex_05 already defined

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LAwb9l3G9tzSGHAi344ax77xRPquks5qoiFCgaJpZM4J5GJ6.gif]

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/35#issuecomment-246106790, or mute the thread https://github.com/notifications/unsubscribe-auth/AEg3AG22i0-IzhNdc-Aeh-jZsuieCMepks5qopQOgaJ pZM4J5GJ6 .

Alex Jordan Mathematics Instructor Portland Community College

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[AAM6LOtyPCtEsDxzzENMh1AIXgAajDGQks5qotCrgaJpZM4J5GJ6.gif]