PCCMathSAC / apex-mbx

Repository for a conversion of APEX Calculus to MathBook XML
2 stars 10 forks source link

Added example to sec_limit_analytically #57

Closed CVollet closed 7 years ago

CVollet commented 7 years ago

I think the . is a style preference. We just need to be consistent. I don't like it lined up with the fraction bar, but I don't really like it in the denominator either. I can change it back.

On Mon, Oct 3, 2016 at 3:12 PM, Alex Jordan notifications@github.com wrote:

@Alex-Jordan commented on this pull request.

In src/sec_limit_analytically.mbx https://github.com/PCCMathSAC/apex-mbx/pull/57#pullrequestreview-2616329 :

@@ -594,7 +594,32 @@

\lim_{x\to 3} \frac{x^3-2 x^2-5 x+6}{2 x^3+3 x^2-32 x+15} \amp = \lim_{x\to 3}\frac{(x-3)\left(x^2+x-2\right)}{(x-3)\left(2 x^2+9 x-5\right)}
         <mrow>\amp =\lim_{x\to 3} \frac{x^2+x-2}{2 x^2+9 x-5}</mrow>
         <mrow>\amp = \frac{10}{40}</mrow>
  • \amp = \frac{1}{4}\text{.}
  • \amp = \frac{1}{4\text{.}}

I think the period should be after the fraction, not after the 4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/57#pullrequestreview-2616329, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBt66euvq6JjLHkVHLVTWvDo05gnnTGks5qwX3mgaJpZM4KNFzR .

Carly Vollet Mathematics Instructor Math Department Co-Chair Math Club Faculty Advisor PCC Cascade, SSB 321 971-722-5564

davidfarmer commented 7 years ago
  • Evaluate \lim\limits_{x\to 9} \frac{\sqrt{x}-3}{x-9 \text{.}}

Similar with the period. If this is discussion-worthy, let's start a thread in the forum.

The period goes after the fraction. The only question is whether it goes inside \text{.} inside the math, or after the closing m.

Alex-Jordan commented 7 years ago

It's a bit more than a style preference. In the code it should definitely go outside of the \frac{}{} arguments for screen reader reasons alone. And then there is new MathJax behavior where you can navigate in and out of the structure of the math, and the period shouldn't be in the denominator for someone zeroed in on that denominator.

I wouldn't necessarily object to a period outside of the frac if CSS was somehow able to push it to appear lower.

On Mon, Oct 3, 2016 at 3:27 PM, CVollet notifications@github.com wrote:

I think the . is a style preference. We just need to be consistent. I don't like it lined up with the fraction bar, but I don't really like it in the denominator either. I can change it back.

On Mon, Oct 3, 2016 at 3:12 PM, Alex Jordan notifications@github.com wrote:

@Alex-Jordan commented on this pull request.

In src/sec_limit_analytically.mbx https://github.com/PCCMathSAC/apex-mbx/pull/57# pullrequestreview-2616329 :

@@ -594,7 +594,32 @@

\lim_{x\to 3} \frac{x^3-2 x^2-5 x+6}{2 x^3+3 x^2-32 x+15} \amp = \lim_{x\to 3}\frac{(x-3)\left(x^2+x-2\right)}{(x-3)\left(2 x^2+9 x-5\right)} \amp =\lim_{x\to 3} \frac{x^2+x-2}{2 x^2+9 x-5} \amp = \frac{10}{40}
  • \amp = \frac{1}{4}\text{.}
  • \amp = \frac{1}{4\text{.}}

I think the period should be after the fraction, not after the 4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/57# pullrequestreview-2616329, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGBt66euvq6JjLHkVHLVTWvDo05gnnTGks5qwX3mgaJpZM4KNFzR .

Carly Vollet Mathematics Instructor Math Department Co-Chair Math Club Faculty Advisor PCC Cascade, SSB 321 971-722-5564

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/57#issuecomment-251245540, or mute the thread https://github.com/notifications/unsubscribe-auth/AEg3ALwkq1qH7zvDF4O4kYwyERrAS21jks5qwYFBgaJpZM4KNFzR .

Alex Jordan Mathematics Instructor Portland Community College