search

PCCMathSAC / apex-mbx

Repository for a conversion of APEX Calculus to MathBook XML
2 stars 10 forks source link

minor manual edits to xref and sbs #71

Closed CVollet closed 7 years ago

Alex-Jordan commented 7 years ago

In a sidebyside, you specify "widths". A "width" on one of its figure or table children does nothing. Also with widths="50% 50%" there will be no margins, so margins="auto" doesn't matter. (And margins="auto" is maybe the default?

I've been gathering my experience with the lab manual, ORCCA, and APEX, and I think I am ready to declare standards for setting widths on these things. I don't think here is the right place for me to post them. But for this example, I would make the sidebyside have widths="47% 47%" and not specify margins. And have no width attribute on the children. Only if there is something seriously bad about that would I consider changing it. For example if the table was too wide.

CVollet commented 7 years ago

I copied this from the MBX sample article. I can take a look at it again, or do you want me to wait until you decide what to do?

On Thu, Nov 10, 2016 at 10:32 AM, Alex Jordan notifications@github.com wrote:

In a sidebyside, you specify "widths". A "width" on one of its figure or table children does nothing. Also with widths="50% 50%" there will be no margins, so margins="auto" doesn't matter. (And margins="auto" is maybe the default?

I've been gathering my experience with the lab manual, ORCCA, and APEX, and I think I am ready to declare standards for setting widths on these things. I don't think here is the right place for me to post them. But for this example, I would make the sidebyside have widths="47% 47%" and not specify margins. And have no width attribute on the children. Only if there is something seriously bad about that would I consider changing it. For example if the table was too wide.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PCCMathSAC/apex-mbx/pull/71#issuecomment-259769382, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBt63Vl7QXyysAsPbkdfv6-1vfJR9nIks5q82NGgaJpZM4KqFcw .

Carly Vollet Mathematics Instructor Math Department Co-Chair Math Club Faculty Advisor PCC Cascade, SSB 321 971-722-5564

Alex-Jordan commented 7 years ago

The scheme used to be based on individual width attributes on the children of the sidebyside. Those width attributes are probably only in the example as remnants from those earlier days.

The 47% 47% standard is what we should adopt as default. Since this is back in Ch1, can you change it to that and push a commit? If it were coming up in Ch2 I'd just do it when I did my pass.

CVollet commented 7 years ago

Ok, it is fixed now.