search

PCCoE-Hacktoberfest-21 / react-app

https://happy-cori-3ff2d3.netlify.app/
2 stars 10 forks source link

new filter option #16

Closed Padmanabh82 closed 2 years ago

netlify[bot] commented 2 years ago

✔️ Deploy Preview for happy-cori-3ff2d3 ready!

🔨 Explore the source changes: c5c65343dd05f0a35f56590fa1b555fb81168ac8

🔍 Inspect the deploy log: https://app.netlify.com/sites/happy-cori-3ff2d3/deploys/6160188326b1a60007d364d5

😎 Browse the preview: https://deploy-preview-16--happy-cori-3ff2d3.netlify.app/

ShamikG17 commented 2 years ago

Hey, @Padmanabh82 can you style the filter dropdown so that it does not overlap the cards? image

Padmanabh82 commented 2 years ago

Sir on my screen it's ok

Padmanabh82 commented 2 years ago

But i will change position absolute to relative

Padmanabh82 commented 2 years ago

But size of your screen is different

ShamikG17 commented 2 years ago

Design should be responsive, so it can work on all screen sizes

Padmanabh82 commented 2 years ago

Ok sir

Padmanabh82 commented 2 years ago

Done !

ShamikG17 commented 2 years ago

It looks like this right now image The navbar is set to fixed position which takes it out of the normal document flow and you'll have to position your filter component accordingly.

Padmanabh82 commented 2 years ago

Sir but when I % in "top" css rule it doesn't work. so, I need to use rem or em but if I use them problem comes like you said

Padmanabh82 commented 2 years ago

It looks like this right now image The navbar is set to fixed position which takes it out of the normal document flow and you'll have to position your filter component accordingly.

done!

Padmanabh82 commented 2 years ago

@ShamikG17 sir?