PCGen / pcgen

Main code and data development for pcgen program release
http://pcgen.org
GNU Lesser General Public License v2.1
432 stars 339 forks source link

[BUG] UI issues due to partial application of (dark) GTK theme #6422

Closed Ghostbird closed 3 years ago

Ghostbird commented 4 years ago

TL;DR; Workaround

Parts of the UI not visible when running on GTK based linux? Override the theme in the PCGen startup so it runs with a light theme that works well with PCGen. You can put export GTK_THEME='Adwaita' near the top of the pcgen.sh file to set it every time the program runs.

Describe the bug

GTK theming is only partially supported, which makes some parts of the UI hard to read in e.g. the dark variant of Cinnamon's standard theme.

To Reproduce

Start PCGen on a system that is running a GTK theme that has colours that wildly differ from the PCGen defaults, such as Adwaita-dark.

Expected behavior

All theme colours are applied, and the colours work well together.

Screenshots

The result of running with a dark theme The result of running with a dark theme

Here the dark theme has been overridden by setting GTK_THEME=Adwaita in the shell before running PCGen Here the dark theme has been overridden by setting `GTK_THEME=Adwaita` in the shell before running PCGen

Desktop

Character File

Irrelevant

Additional context

This is not a big issue, but it would be nice if there was a way to inform the user of this workaround. Ideally apply it automatically until such a time where a dark theme is fully supported.

grimreaper commented 3 years ago

We are migrating from Swing to JavaFX. I believe only Swing supports GTK theming. I don't think it is like;y we'll support this.

Ghostbird commented 3 years ago

We are migrating from Swing to JavaFX. I believe only Swing supports GTK theming. I don't think it is like;y we'll support this.

Then I assume that once the migration is complete, it probably won't use the dark theme at all. That would be fine. This issue arose because only some parts of the UI were dark.

Ghostbird commented 3 years ago

I'm closing this as it's probably not going to be an issue once the migration is completed. Even if we'd lose dark theme support, the UI would at least work properly.