search

PCLLAB / jsPsych-Angular

Angular version of jsPsych.
MIT License
2 stars 0 forks source link

Merging into jsPsych repo? #2

Open jodeleeuw opened 8 years ago

jodeleeuw commented 8 years ago

Hi,

This looks like a really useful set of features being developed on this fork, and it seems like it targets at least one of the major open issues in the jsPsych repository: https://github.com/jodeleeuw/jsPsych/issues/244.

Are you interested in merging into the main repository at some point? Or is this a separate fork at this point?

Best, Josh

garrickb commented 8 years ago

Most of our styling is going to be done using the Angular Material library, which I think is a very specialized use-case for us, and involves changing which HTML elements jsPsych injects into the DOM (for example, it uses <md-progress-linear> for a progress bar).

I can see how having SASS in the jsPsych library would be useful, and that would require a change on how development is done for jsPsych by requiring something like gulp to compile the SASS files into CSS. The only change we've done on that in this repo is condensing the styling a bit into a nested structure in the SASS file.

With that being said, I don't think the work we've done here would carry over very well to the main jsPsych repo, since we have made changes in here mainly for our own special uses.