tweak DRS creation script to use drsList (#37)

PCMDI / input4MIPs_CVs

Controlled Vocabularies (CVs) for use in input4MIPs

https://input4mips-controlled-vocabularies-cvs.readthedocs.io/en/stable/

Creative Commons Attribution 4.0 International

5 stars 1 forks source link

tweak DRS creation script to use drsList (#37) #116

Closed durack1 closed 2 months ago

durack1 commented 2 months ago

Description

Tiny tweak to logic to prevent problems when "nice to have" metadata/global attributes are missing

Checklist

Please confirm that this pull request has done the following:

[ ] Documentation added (where applicable)
[x] Changelog item added to changelog/

Ref #37

@znichollscr will need to check that "reusing" a closed issue (#37) isn't going to cause problems with the changelog process you have going on

github-actions[bot] commented 2 months ago

No changes to the database between 'main' branch and c0f66c532a2e91854dc7e6c79c4795249120558e

znichollscr commented 2 months ago

@znichollscr will need to check that "reusing" a closed issue (#37) isn't going to cause problems with the changelog process you have going on

It's all fine. The tweak is that the changelog entry should have the number of the pull request (in this case 116), not the number of the issue. Otherwise lgtm

durack1 commented 2 months ago

Ah ok will change. Your MR vs PR nomenclature was a little confusing to me

github-actions[bot] commented 2 months ago

No changes to the database between 'main' branch and 8615c39a13949b75b6a75a4b049537f5c0778b51

znichollscr commented 2 months ago

Your MR vs PR nomenclature was a little confusing to me

Ooops, I am very bad at being consistent on that front.

Looks all good now, merge whenever you're happy