search

PCMDI / input4MIPs_CVs

Controlled Vocabularies (CVs) for use in input4MIPs
https://input4mips-controlled-vocabularies-cvs.readthedocs.io/en/latest/
Creative Commons Attribution 4.0 International
1 stars 1 forks source link

Tweaks to source_id and data registration formats #38

Closed durack1 closed 1 month ago

durack1 commented 1 month ago

Working with @znichollscr, we plan to implement a number of updates to streamline the capture of information from the dataset-level (defined by a source_id registration) and file-level (contained as global attributes/metadata in a single file). I will capture recommended changes below. Lose existing |dataProviderFile entry altogether.

lose convert/move add
core _status, nominal_resolution convert to list: frequency, grid_label, realm, target_mip
dataProviderExtra
esgfIndex _status

To file-level, required global_attributes are: activity_id, tracking_id, nominal_resolution (remove institution, table_id)

For reference this is how a registration looks currently https://github.com/PCMDI/input4MIPs_CVs/blob/07653ab34adb2fd52798add18aa6e17bdca8b1a1/input4MIPs_source_id.json#L1132-L1171

Will need to add to repo CV list, input4MIPs_regions.json following the CF standard region list (here) and converted to JSON in the obs4MIP-cmor-tables repo (here). As work continues to be finalized upstream in the mip-cmor-tables the reproduction of these CVs in this repo could be removed, rather deferring to the upstream sources as the definitive record

durack1 commented 1 month ago

@znichollscr I also may not have mentioned that I have a couple of reusable functions defined in input4MIPsFuncs.py, the checkTrackingId function might be a useful one in particular

znichollscr commented 1 month ago

Thanks Paul! I'll submit a PR tomorrow with my proposal for how this could work.

On Wed, Jul 10, 2024, 21:40 Paul J. Durack @.***> wrote:

@znichollscr https://github.com/znichollscr I also may not have mentioned that I have a couple of reusable functions defined in input4MIPsFuncs.py https://github.com/PCMDI/input4MIPs-cmor-tables/blob/master/src/input4MIPsFuncs.py, the checkTrackingId function might be a useful one in particular

— Reply to this email directly, view it on GitHub https://github.com/PCMDI/input4MIPs_CVs/issues/38#issuecomment-2221285939, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3KEXH5APNIFC25P54TUSW3ZLWE3FAVCNFSM6AAAAABKVRX76GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGI4DKOJTHE . You are receiving this because you were mentioned.Message ID: @.***>

znichollscr commented 1 month ago

See #39

durack1 commented 1 month ago

It seems this is now redundant, so closing