PCMDI / obs4MIPs-cmor-tables

JSON Tables for CMOR3 to create obs4MIPs datasets
Other
6 stars 3 forks source link

obs4MIPs_Amon.json ttbr entry has bad values #115

Closed JimBiardCics closed 7 years ago

JimBiardCics commented 7 years ago

The obs4MIPs_Amon.json entry for ttbr has bad values. It is causing CMOR to fail. The entry should be:

"ttbr":{ "cell_measures":"", "cell_methods":"time: mean", "comment":"", "dimensions":"longitude latitude time", "frequency":"mon", "long_name":"Top of Atmosphere Brightness Temperature", "ok_max_mean_abs":"", "ok_min_mean_abs":"", "out_name":"ttbr", "positive":"", "standard_name":"toa_brightness_temperature", "type":"real", "units":"K", "valid_max":"", "valid_min":"" },

durack1 commented 7 years ago

@JimBiardCics looks like these are the differences, positive is clearly wrong, what about valid_max, valid_min? (As we discussed yesterday, these would need to be defined in cmor.set_variable_attribute and won't propagate directly from the table, but are useful registered content if they are hard limits)

        "ttbr":{
...
            "positive":"time: mean",
...
            "valid_max":"375.0",
            "valid_min":"140.0"
},
JimBiardCics commented 7 years ago

@durack1 They aren't hard limits, and the min limit value is a bit of a mystery to me anyway. I think we threw values in those entries because we thought they would go into the output file, and weren't thinking about this being a general purpose entry for anyone that wants to create a brightness temperature variable.

durack1 commented 7 years ago

@JimBiardCics, ok so you're recommending that these 3 quirky fields are set to ""?

JimBiardCics commented 7 years ago

@durack1 Yes.