PCMSolver / pcmsolver

An API for the Polarizable Continuum Model
http://pcmsolver.readthedocs.io/
GNU Lesser General Public License v3.0
32 stars 21 forks source link

Mixed fixes for Conda build #158

Closed robertodr closed 6 years ago

robertodr commented 6 years ago

Description

These are some mixed fixes before the official 1.2.0 release. Mostly motivated by inconsistencies/bugs encountered by @loriab while packaging for the Conda package manager.

Todos

Types of changes

Status

MinazoBot commented 6 years ago
1 Warning
:warning: You have removed source files without updating .gitattributes.

Generated by :no_entry_sign: Danger

arnfinn commented 6 years ago

your bot is not happy...:)

codecov[bot] commented 6 years ago

Codecov Report

Merging #158 into release/1.2.Z will increase coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/1.2.Z     #158      +/-   ##
=================================================
+ Coverage          69.83%   70.01%   +0.17%     
=================================================
  Files                 92       92              
  Lines               5606     5592      -14     
=================================================
  Hits                3915     3915              
+ Misses              1691     1677      -14
Impacted Files Coverage Δ
src/utils/Factory.hpp 82.35% <ø> (ø) :arrow_up:
src/cavity/Element.hpp 100% <ø> (+45.45%) :arrow_up:
src/interface/Input.cpp 85.93% <ø> (ø) :arrow_up:
src/utils/SplineFunction.hpp 100% <ø> (ø) :arrow_up:
src/utils/Sphere.hpp 100% <0%> (+57.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfda032...75b5c89. Read the comment docs.