Closed robertodr closed 6 years ago
1 Warning | |
---|---|
:warning: | You have removed source files without updating .gitattributes . |
Generated by :no_entry_sign: Danger
your bot is not happy...:)
Merging #158 into release/1.2.Z will increase coverage by
0.17%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## release/1.2.Z #158 +/- ##
=================================================
+ Coverage 69.83% 70.01% +0.17%
=================================================
Files 92 92
Lines 5606 5592 -14
=================================================
Hits 3915 3915
+ Misses 1691 1677 -14
Impacted Files | Coverage Δ | |
---|---|---|
src/utils/Factory.hpp | 82.35% <ø> (ø) |
:arrow_up: |
src/cavity/Element.hpp | 100% <ø> (+45.45%) |
:arrow_up: |
src/interface/Input.cpp | 85.93% <ø> (ø) |
:arrow_up: |
src/utils/SplineFunction.hpp | 100% <ø> (ø) |
:arrow_up: |
src/utils/Sphere.hpp | 100% <0%> (+57.14%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dfda032...75b5c89. Read the comment docs.
Description
These are some mixed fixes before the official 1.2.0 release. Mostly motivated by inconsistencies/bugs encountered by @loriab while packaging for the Conda package manager.
Todos
PUBLIC
attribute of the PCM library, meaning that it is transitively inherited by dependent targets. Fixes #157-std=c++11
flag (or similar) instead of checking for compiler features. This is a step towards #57 and should act as a deprecation notice for older compilers. As a result, I have effective immediately dropped support for GCC 4.6 and earlier. It's 2018, upgrade your compiler.Types of changes
Status