PCMSolver / pcmsolver

An API for the Polarizable Continuum Model

http://pcmsolver.readthedocs.io/

GNU Lesser General Public License v3.0

32 stars 21 forks source link

Only use one getkw.py #161

Closed robertodr closed 6 years ago

robertodr commented 6 years ago

Description

The Python version of the getkw.py file is unnecessary and has been removed.

How Has This Been Tested?

I've tested that this works both with Python 2.7 and Python 3.6

Todos

Developer Interest
- [x] Simpler installation of the Getkw Python module
- [x] Update pull request template. There is a checkmark for cherry-picking to the latest release branch.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Status

[x] Ready to go
[x] Cherry-pick to release/1.2

MinazoBot commented 6 years ago

	3 Warnings
:warning:	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.
:warning:	Consider adding supporting documentation to this change. Documentation sources can be found in the `doc` directory.
:warning:	Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry:

* [#161](https://github.com/PCMSolver/pcmsolver/pull/161): Only use one getkw.py - [@robertodr](https://github.com/robertodr)

Generated by :no_entry_sign: Danger

codecov[bot] commented 6 years ago

Codecov Report

Merging #161 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files          92       92           
  Lines        5592     5592           
=======================================
  Hits         3915     3915           
  Misses       1677     1677

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d70435...0fd7cf4. Read the comment docs.