search

PCMSolver / pcmsolver

An API for the Polarizable Continuum Model
http://pcmsolver.readthedocs.io/
GNU Lesser General Public License v3.0
32 stars 21 forks source link

import dot has gone again in 1.2.0 release! #165

Closed loriab closed 6 years ago

loriab commented 6 years ago

I believe that the relative dot import .pyparsing added in #164 should be in the v1.2.0 release here

arnfinn commented 6 years ago

It is here #164, not yet merged.

Cherry pick from master

loriab commented 6 years ago

But the dot problem was discovered before the release tag. Why mint a tag with a known bug? I know how to get at the commit, was just trying to package pcmsolver from a tag, rather than from a commit or from a tag + patch.

arnfinn commented 6 years ago

The release branch was made right before the patch came into master, so I believe we just forgot to cherry pick it before the release was minted. Not sure if @robertodr is active today, to make a new release?

loriab commented 6 years ago

I think he's back in town tonight. Dropped him a note on psi4/psi4#988 for when he can do a new tag. Just working from my fork now and calling it 1.2.0rc2. Thanks for your help.

robertodr commented 6 years ago

Apologies, was too hasty in preparing the tag to catch this one... I'll mint 1.2.1 ASAP

arnfinn commented 6 years ago

Fixed here: 3b76ff724