PCMSolver / pcmsolver

An API for the Polarizable Continuum Model
http://pcmsolver.readthedocs.io/
GNU Lesser General Public License v3.0
32 stars 21 forks source link

Cherry picks from release/1.2 #166

Closed arnfinn closed 6 years ago

arnfinn commented 6 years ago

Description

Cherry-picked all the commits that were on the release/1.2 branch but not on the master branch.

Motivation and Context

Make sure master is up to date. master is now identical to release/1.2.

Types of changes

Questions

Status

MinazoBot commented 6 years ago
1 Warning
:warning: There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by :no_entry_sign: Danger

codecov[bot] commented 6 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files          92       92           
  Lines        5592     5592           
=======================================
  Hits         3915     3915           
  Misses       1677     1677

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c2e836...dd493cf. Read the comment docs.

arnfinn commented 6 years ago

@robertodr Is this OK?

robertodr commented 6 years ago

Yes, this should be merged back to `master, but I haven't had time to think about it carefully yet.