Closed robertodr closed 5 years ago
1 Warning | |
---|---|
:warning: | Consider adding supporting documentation to this change. Documentation sources can be found in the doc directory. |
Generated by :no_entry_sign: Danger
Merging #178 into release/1.2 will increase coverage by
0.12%
. The diff coverage is100%
.
@@ Coverage Diff @@
## release/1.2 #178 +/- ##
===============================================
+ Coverage 72.52% 72.65% +0.12%
===============================================
Files 92 92
Lines 5668 5693 +25
===============================================
+ Hits 4111 4136 +25
Misses 1557 1557
Impacted Files | Coverage Δ | |
---|---|---|
include/Citation.hpp | 100% <ø> (ø) |
:arrow_up: |
src/interface/Meddle.hpp | 100% <ø> (ø) |
:arrow_up: |
src/cavity/GePolCavity.hpp | 50% <ø> (ø) |
:arrow_up: |
src/bin/run_pcm.cpp | 95.34% <100%> (+0.11%) |
:arrow_up: |
src/cavity/GePolCavity.cpp | 91.17% <100%> (+0.38%) |
:arrow_up: |
src/interface/Meddle.cpp | 68.78% <100%> (ø) |
:arrow_up: |
src/utils/MathUtils.hpp | 98.26% <100%> (+0.24%) |
:arrow_up: |
api/pcmsolver.f90 | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7507745...54679e7. Read the comment docs.
@ilfreddy I am merging so I can finish up a new release. You've looked at this changes in the previous PR anyway
Implements removal of finite elements with too small area (<= 1.0d-04) These finite elements can cause the calculation of the S and D matrices to be numerically unstable. For example, the S matrix can end not being symmetric positive-definite. I've also split the printing of the citation and set up report into two separate functions.
Types of changes
Status