search

PCMSolver / pcmsolver

An API for the Polarizable Continuum Model
http://pcmsolver.readthedocs.io/
GNU Lesser General Public License v3.0
32 stars 21 forks source link

Fails ungracefully when built from the tarball: AttributeError: 'NoneType' object has no attribute 'group' #198

Open yurivict opened 2 years ago

yurivict commented 2 years ago

Build from the tarball fails with git executable present :

[ 10%] Building CXX object src/CMakeFiles/pcm-objlib.dir/green/AnisotropicLiquid.cpp.o
Traceback (most recent call last):
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 367, in <module>
    ans = reconcile_and_compute_version_output(quiet=args.formatonly)
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 150, in reconcile_and_compute_version_output
    res.update(collect_version_input_from_git())
  File "/disk-samsung/freebsd-ports/science/pcmsolver/work/pcmsolver-1.3.0/tools/versioner.py", line 95, in collect_version_input_from_git
    if mobj.group('tag'):
AttributeError: 'NoneType' object has no attribute 'group'

When git executable is missing - build succeeds.

Package builder isn't allowed to use git to download anything, so it should successfully build from the tarball w/ or w/out git present.

Python-3.8 FreeBSD 13