search

PCRE2Project / pcre2

PCRE2 development is now based here.
Other
919 stars 191 forks source link

Updates to Windows tests (RunTest.bat) #468

Closed alexdowad closed 2 months ago

alexdowad commented 2 months ago

The comments in RunTest.bat state that @zherczeg added 16-bit and 32-bit support... could he confirm that 544dfb00 reflects his intentions correctly?

I was able to run the CI jobs in my forked repo and the Windows 32-bit job passed. I guess that's a good thing... though since I have never seen it fail, I don't really know for sure that it is testing anything 😅

PhilipHazel commented 2 months ago

Is this ready now?

carenas commented 2 months ago

Is this ready now?

Tested locally as well using the command line but it seems to fail with the GUI, not sure if it is a regression though.

alexdowad commented 2 months ago

Is this ready now?

Yes!

carenas commented 2 months ago

Is this ready now?

Tested locally as well using the cmdline but it seems to fail with MSVC, not sure if it is a regression though.

Indeed, not a regression, but fixing tests for the 32-bit library when the 16-bit library was not enabled

PhilipHazel commented 2 months ago

I merged; there now seems to be a test failure...

alexdowad commented 2 months ago

I merged; there now seems to be a test failure

I'm looking into it. Thanks for mentioning.

alexdowad commented 2 months ago

Hmm. I can't see any failure in the GitHub Actions tab. Is there somewhere else where I can see it?

carenas commented 2 months ago

Hmm. I can't see any failure in the GitHub Actions tab. Is there somewhere else where I can see it?

Should be visible here (the red X next to the last commit in the "code menu")

The failure wasn't caused by this code though but just a badly timed deprecation.

@alexdowad: are you still working in a fix?, the changes to the scorecard job included in this commit seem to work from my own tests, but it might be worth looking more into it to make sure it is well maintained IMHO.