search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
Other
10.55k stars 1.53k forks source link

Qt: Simplify incompatible savestate message #11243

Closed kamfretoz closed 1 month ago

kamfretoz commented 1 month ago

Description of Changes

This PR attempts to simplify the incompatible savestate warning message to be more easily understandable and digestible.

Preview:

Screenshot_20240513_211027

Rationale behind Changes

Hoping that people would actually read the message.

Suggested Testing Steps

Check if the message shows up properly.

stenzek commented 1 month ago

It won't make a difference to the stupidity of some users. Remember, it's a vocal minority.

Try to keep the change limited to the message. Formatting the whole file just makes the diff messy.

(Yes, pcsx2 needs a project wide clang format, I've pushed for it, but it wasn't received well)

kamfretoz commented 1 month ago

The formatting changes has been reverted.

On the subject of the message itself, i feel like it could've been worded better, at the very least. This just makes the intentions more clearer to the user and shaving off unnecessary bits.

stenzek commented 1 month ago

I mean, I don't really care if the message is changed one way or another, but if you think it's going to make a difference with users, you're going to be disappointed :P