GameDB: fix tearing like issues on KH2 when upscaled

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator

https://pcsx2.net

Other

10.55k stars 1.53k forks source link

GameDB: fix tearing like issues on KH2 when upscaled #11266

Closed GovanifY closed 4 weeks ago

GovanifY commented 1 month ago

Description of Changes

Switches KH2 roundSprite mode to half to fix a graphical upscaling artifact.

Rationale behind Changes

https://github.com/PCSX2/pcsx2/issues/11265 reported tearing-like issues that didn't seem to happen in previous revisions when upscaling KH2. Bisecting led me to https://github.com/PCSX2/pcsx2/pull/7545 , which fixes other upscaling issues with KH2, but also introduces this graphical bug.

Switching roundSprite to half seems to fix the bug while not introducing other obvious ones (eg, Mulan's cutscene as shown in @JordanTheToaster 's PR works fine under half mode.

Suggested Testing Steps

See if anything in KH2 breaks pretty much, as I didn't see any discussion as to why we used full rounding in the past, this might break something I'm unaware of. Nevertheless opening this PR to at least talk about it.

Xaddgx-Absol-Brasse commented 1 month ago

Here are comparison shots of Round Sprite between 2 and 1. 2 Introduces subtle line tearing on upscaling, whereas 1 does not. Here are screenshots with distance, and also zoomed in. You can see a line going down the eye more clearly when it's zoomed in, but it extends all the way down beyond. Also included a screenshot of the same Mulan cutscene on Round Sprite 1 just to show it doesn't reintroduce the issue of floor problems. For the eye shots, feel free to zoom in closer with ctrl+mouse wheel if needed, I did the best I could. https://imgur.com/a/zmZnSMt

bigol83 commented 1 month ago

Ok, i zoomed in and took a screenshot so it is much more visible

Round Sprite 1 (Half) rs1

Round Sprite 2 (Full) rs2

Xaddgx-Absol-Brasse commented 1 month ago

1 Round Sprite appears to offset emanating glows from where they should be when upscaled. The higher the upscale, the more offset it becomes. https://imgur.com/a/2kayz6P

bigol83 commented 1 month ago

1 Round Sprite appears to offset emanating glows from where they should be when upscaled. The higher the upscale, the more offset it becomes. https://imgur.com/a/2kayz6P

So yeah, even if introduces that line it seems like in general Round Sprite 2 (full) is better for upscaling.

JordanTheToaster commented 1 month ago

Changing the HPO from Special to Align to Native to better align the bloom in the world as well as changing back to round sprite half to fix aforementioned issues.

Before:

After: