search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
Other
10.64k stars 1.55k forks source link

[Feature Request]: Include nvm data in TAS input file #11474

Open sestain opened 1 week ago

sestain commented 1 week ago

Description

Include bios' nvm file into input recording file (p2m2) so when the TAS is playbacked it will use the nvm from the input recording's file.

Reason

Makes it easier to share input recording files when BIOS configuration is already included and doesn't need replacing nvm manually. If nvm is different than when creating the inputs, syncing the input playback wouldn't be possible, and it would desync every time.

Examples

We would like to not do this, instead have it automatically be correct nvm data. https://youtu.be/wToFqC1FrDo

Mrlinkwii commented 1 week ago

May I ask what info from the nvm is needed ?

sestain commented 1 week ago

May I ask what info from the nvm is needed ?

I'm not sure what is required from it but since it's a small file I don't see why it couldn't be included, and for bios to understand it correctly I assume all of it.

stenzek commented 1 week ago

Including extra state only in tas is silly, makes tas-specific difficult-to-debug issues. Better off including it in the save state, but then that could conflict with what's on disk when loading.