PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.31k stars 1.58k forks source link

[BUG]: Game loaded using 'Host Filesystem' ignores cheat pnach file. #11533

Open JpDeathBlade opened 1 month ago

JpDeathBlade commented 1 month ago

Describe the Bug

I am currently working on a pnach file for Resident Evil: Outbreak File 1. I used THIS guide to extract the game files into a folder, and load the game using an .ELF file. This helps decrease load times when playing the game which is super helpful and the ideal way to play this particular title. When I do this, the cheat menu does not populate with cheats. The log window shows that cheats are found. If I load the same game up as an .ISO the cheat menu populates as expected. I've only tested this with Resident Evil: Outbreak File 1, my assumption is that this happens on other games as well.

Reproduction Steps

Note: If you select "Edit Cheats..." from the Tools menu running any version of the game, .ELF or .ISO, it opens the same file.

Expected Behavior

Expected: This menu when using any version of the game should populate with cheats. Screenshot 2024-07-10 171609

Actual: When using a 'Host Filesystem" version of the game, launching from a .ELF, the cheat menu doesn't populate even tho the log says that it found cheats. Screenshot 2024-07-10 171515

PCSX2 Revision

1.7.5973

Operating System

Windows 11

If Linux - Specify Distro

No response

Logs & Dumps

No response

CookiePLMonster commented 1 month ago

This is not a suggested fix, but I'd like you to check something so I could confirm that your issue is identical to a bug I was reported months ago and could not reproduce it - do the cheats load when you drop the serial from the pnach name, renaming the cheats to 32097C02.pnach?

JpDeathBlade commented 1 month ago

Do the cheats load when you drop the serial from the pnach name, renaming the cheats to 32097C02.pnach? They do! Renaming the file has them showing up correctly and they work when toggled.

To add some more details that might be useful: I started testing with other versions of the game and I was able to get it to generate the cheat file by clicking "Edit Cheats..." with different CRCs (for this game it's 32097C02, 32088394, 03C8F393, and C5B37067 so far). If I click the "All CRCs" toggle it will load cheats from all the files BUT only the ones with a matching CRC work. This only effects the CHD/ISO versions. The ELF version ignores the "All CRCs" option and only loads cheats with your suggested change. I think this toggle was causing any existing pnach files to open which is why I couldn't get PCSX2 to generate new ones in my original report.

I can give an example; Here is the Infinity Mode cheat again (I swapped a 2 for a 7 because it should be a bitwise cheat) [Game Mode\Infinity] patch=1,EE,70301D7F,extended,00000001

I have this cheat in all three of my pnach files. I gave it a different group/name in each file so it would show up multiple times. If I have "All CRCs" checked, then it will show it multiple times, but it won't actually work when I click on it unless it's from the pnach file with the matching CRC.

CookiePLMonster commented 1 month ago

Thanks! This confirms for me that both are the same issue, that is good to know.