RedPanda4552
commented
4 months ago Memory cards store timestamps in the directory entries as JST, that is simply a design quirk of the system and is accounted for by the running game or the BIOS. We in turn copy those raw timestamps from the directory entries into the index files. That is accurate and we are not going to change that, it makes no sense to add more timezone conversions when they are unnecessary.
Converting a folder back to a file and losing all timestamps is an interesting problem though. The conversion process should simply issue sequential reads across the entire card, which suggests something is wrong with how folder cards are assembling their virtual FAT. That has potential to be a clue to some other issues they have been having as well where it seems problems are coming from the ephemeral nature of the FAT on folder memcards.
Mike3137
Describe the Bug
Update: Just scroll down to my last comment for TLDR.
PCSX2 currently does not take into account at all that PS2 uses UTC+9 timestamps. (Well actually it seems to be +9 from whatever the bios time is set to. PCSX2 seems to default bios to UTC time which is sensible.) This results in the Unix time in the index files is 9 hours into the future, it is converted back again though so it is displayed correctly in bios. However it results in some strange timestamps when converting back and forth between file and folder type. Also note that converting Folder MC -> File MC reverses the file order and rootdir timestamps are set to all zero bytes. Check my log below for more details.
Reproduction Steps
Expected Behavior
PS2 timestamps should be interpreted correctly and stored as an accurate Unix time, and converted back again to ps2 format correctly.
In my own program i simply do something like this:
What about DST you may ask. Neither UTC nor JST (UTC+9) uses DST, they're always 9 hours apart. Once it has been converted to unix time you can do what you want with it, display it as UTC or local time or whatever. I noticed the code once had something similar to this, but I think it maybe only converted forward, not back again.
PCSX2 Revision
v1.7.5976
Operating System
Linux (64bit) - Specify distro below
If Linux - Specify Distro
Arch
Logs & Dumps
Output from my own program below. File MC timestamps are interpreted as UTC+9 (since that is how PS2 stores them) and displayed as UTC. (Meaning simply -9 hours from raw card date) Folder MC timestamps simply converts the unix time from the index file to UTC. pcsx2 stores the unix time in index files as +9 hours into the future for some reason. (Interprets the PS2 date (UTC+9) as if it was UTC). It is converted back correctly when read so it displays correctly in bios anyway. Actual Unix time around the same time (after) as tests: 1720773629
Sample regular memory card file (everything is correct):
Memory card folder: All of the unix times stored in index files are +9 hours into the future.
Ignore rootdir timestamps for Folders MC, they're generated by my program at runtime. Timestamps on Folder MC are 9 hours into the future because of the unix time stored by pcsx2 in index files.
converted to file: PCSX2 sets rootdir timestamps to all zero bytes when converting FolderMC -> File MC, displayed as 1899-12-30 15:00:00 here, why not simply generate a rootdir time from current time instead? On conversion to File MC, save dirs gets -9 hours from the unix time which results in the correct time again. Files gets -9 hours from the accurate date though. (-18 from the unix time stored) Note that the file order has been reversed. Also every time it is converted to file some extra time is added to file timestamps, 2-3 seconds here. (Don't know what's going on maybe it's based on current time when converted or something)
converted back to folder:
Ignore rootdir timestamps for Folders MC, they're generated by my program at runtime.
converted back to file again: 67 extra seconds added to file timestamps for some reason. (Maybe has to do with when it was converted or something.)
converted back to folder again: