search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.91k stars 1.63k forks source link

Meta: GS HW half bottom screen issue #1339

Open gregory38 opened 8 years ago

gregory38 commented 8 years ago

Let's list all games impacted. This way it would be easier to check any potential implementation.

Games confirmed still have the HW half-bottom screen issue:

Games unconfirmed if recent fix solved the issue:

Games confirmed to be have been resolved:

Extra

Related #2022

gregory38 commented 8 years ago

So I implemented something for one of the half-screen bug. Now it is time for you to work :+1:

If it works well, it would replace some CRC hack and we will enable it by default. I would need that you test those game with the following config

You can compare with CRC set to minimal which is correct.

Here a list of games that are for sure impacted by the change

Extra (seem to contains several CRC hacks so might be harder to see)

FlatOutPS2 commented 8 years ago

Ty The Tasmanian Tiger works great with the hack in both D3D and OGL, didn't notice any change with old CRC hack.

refractionpcsx2 commented 8 years ago

Simpsons game also works great with the hack on DX and OGL :) . Annoying thing on there though (very unrelated but thought I'd mention it) when upscaling, the half pixel offset stops the cell shading being outside the characters but only horizontally, the vertical is still off, not sure why.

gregory38 commented 8 years ago

Ok. It is a good start. Maybe the game uses a different HPO on the Y axis (already have enough on my plate :p )

refractionpcsx2 commented 8 years ago

That's fine, I was just planting the seed for possible future things to look in to, it isn't important :P

FlatOutPS2 commented 8 years ago

@refractionpcsx2 Can you share a GS Dump of The Simpsons Game?

refractionpcsx2 commented 8 years ago

Sure, here you go: http://www.filedropper.com/simpsons-offset

I think i had the half pixel offset on in this, hence the screenshot.

FlatOutPS2 commented 8 years ago

In hardware mode I can only see the contents of the dump for two short flashes when I resize or open the window. Otherwise it stays completely black. :S

refractionpcsx2 commented 8 years ago

:/ might need to do a longer dump then...

refractionpcsx2 commented 8 years ago

@FlatOutPS2 Here's a longer dump for you done in SW mode: http://www.filedropper.com/simpsons-offsetlong

FlatOutPS2 commented 8 years ago

Thanks, that dump works great. But I don't really see the issue. The cel-shading looks fine vertically with the HPO hack.

refractionpcsx2 commented 8 years ago

Try native x3, homer has two lots of hair on the side of his head

FlatOutPS2 commented 8 years ago

Yes, he seems to have one brown and one black. But it looks the same on native/SW mode, only the lines are thinner at higher than native resolution.

AmbientMalice commented 8 years ago

Delta Force: Black Hawk Down seems fixed by hack. Shadows flicker, but that's probably another problem.

gsdx_20160920154905

gregory38 commented 8 years ago

@AmbientMalice does the shadow flicker if you enable the CRC ?

AmbientMalice commented 8 years ago

You mean CRC Hack Level? Makes no difference. Here are the shadows for reference.

gsdx_20160920174531

gregory38 commented 8 years ago 
You mean CRC Hack Level? Makes no difference.

Perfect. First goal is to replace various CRC with a generic code that will always be enabled.

For the shadow, I suspect a color shuffling effect wrongly detected due to a sub frame/depth buffer. Low priority.

FlatOutPS2 commented 8 years ago

It could be CRC hack for an issue that only affects certain missions though.

gregory38 commented 8 years ago

I pushed the code for a generic function in #1579 Hopefully we could reduce a bit the huge list above :)

gregory38 commented 8 years ago

I merged my commit to handle some half-screen bugs. The guy that generates me this huge list can test all of them :p

Someone said Mercenaries was better. I would like a confirmation. And someone to test the 2 too.

prafullpcsx2 commented 8 years ago

I can confirm that both mercenaries games are indeed fixed.

FlatOutPS2 commented 8 years ago

Did the mercenaries games have the half-clear(bottom half of the screen not getting cleared properly) issue?

gregory38 commented 8 years ago

They got an half screen issue. Previous clear function didn't help but now the code is more generic so it likely helps.

prafullpcsx2 commented 8 years ago

xmen origins wolverine is not fixed, so something else is going on there.

prafullpcsx2 commented 8 years ago

Gun fighter 2 also fixed. :+1:

FlatOutPS2 commented 8 years ago

Ford Racing 2, Killzone, NFS Underground 2 and WRC half-screen issues are all still there.

refractionpcsx2 commented 8 years ago

Destruction Derby still has the half screen issue too

refractionpcsx2 commented 8 years ago

Destruction Derby still has the half screen issue too Killzone confirmed still broken. Getaway also still broken.

FlatOutPS2 commented 8 years ago

Where does The Getaway have the issue?

refractionpcsx2 commented 8 years ago

as soon as you go in to "new game" and the intro starts, you get the lighting cut off half way through the screen

FlatOutPS2 commented 8 years ago

You mean The Getaway Black Monday?

refractionpcsx2 commented 8 years ago

Yeah, sorry, didn't realise there was more than one :P

It's the US version I've got.

FlatOutPS2 commented 8 years ago

A few more still broken ones: 007: Everything Or Nothing (MI6 training) Crash Twinsanity FIFA games (2006 onwards) Need For Speed Hot Pursuit 2 Tekken5 (heat effect burning temple) Total Immersion Racing(fog in wet races)

pepiczech77 commented 8 years ago

Some other games still affected: Killzone NFS Carbon (if it is half screen issue, seems a bit different) NFS Underground NFS Underground 2 (also shadows seem incorrect in HW mode) TOCA Race Driver 3 (in distance when it is rain) but broken menus in HW mode are probably fixed

FlatOutPS2 commented 8 years ago

NFS Carbon (if it is half screen issue, seems a bit different)

Looks like a normal half-screen issue to me.

I updated the first post a little to show the games that are confirmed to still have the issue, so we don't keep checking the same games.

gregory38 commented 8 years ago

@prafullpcsx2 could you retest X-men origins - wolverine

Edit: if it is still broken could you generate me a gs dump. Thanks.

prafullpcsx2 commented 8 years ago

Although God of War 2 is fixed now Xmen is still messed up. It seems to have separate half screen issues in menu as well as ingame (may be same). Here is gsdump of both. http://www.filedropper.com/xmenorigins

pepiczech77 commented 8 years ago

@FlatOutPS2 Here are screenshots. I am not sure if it is related at all, but I can somehow see some horizontal plane there. (see screenshot, I highlited it on one of them) Also the game is green in HW mode. I think it's a known issue. Also I have no idea why the screenshots are stretched. gsdx_20160930212916 gsdx_20160930212916 - kopie SW mode gsdx_20160930213803

gregory38 commented 8 years ago

@prafullpcsx2 thanks you. Fix pushed.

prafullpcsx2 commented 8 years ago

@gregory38 Good job. It works fine now :+1:

FlatOutPS2 commented 8 years ago

MGS3 codec still has the issue.

AmbientMalice commented 8 years ago

@FlatOutPS2 PAL version, I assume?

FlatOutPS2 commented 8 years ago

Yes, it only affects PAL versions as far as we know.

FlatOutPS2 commented 8 years ago

I happened to find a demo of Gunfighter II, and tried it with the latest git and it still showed the half-screen issue. @prafullpcsx2 Can you check if it's still fixed?

prafullpcsx2 commented 8 years ago

@FlatOutPS2 : Sorry I didn't notice your comment. I rechecked Gunfighter II today and yes it's fixed.

refractionpcsx2 commented 8 years ago

Can someone test Superman Returns? Seems to show the bug in #934 but haven't tried it to find out. Would like to add it to the "resolved" list, just for informational purposes.

prafullpcsx2 commented 8 years ago

Call of duty World at War : Final Front is also fixed.

FlatOutPS2 commented 8 years ago

Judge Dredd has also been fixed.

World War Zero has been fixed partially, the initial half-screen issue was hiding another that is not fixed. :p

MrCK1 commented 8 years ago

Can anybody confirm if #318 (Price of Persia: Warrior Within) needs to be added here? According to the issue, the bottom half of the screen has greenish tint on OGL HW

FlatOutPS2 commented 8 years ago

As that issue is a few months old, I asked if the issue is still active over there.