PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.45k stars 1.59k forks source link

Berserk - FMV missing subs in HW (UI was fixed) #1526

Closed vortexofdoom closed 5 months ago

vortexofdoom commented 8 years ago
ssakash commented 8 years ago

Simply redirecting to a bug report on the forums isn't helpful. Please follow the template mentioned over here. Providing status of the issue on latest development build would also be useful.

vortexofdoom commented 8 years ago

I updated it, hope it's more helpful now!

ssakash commented 8 years ago

Thanks for the quick update!

gregory38 commented 8 years ago

Could someone test build from #1550 with UserHacks_AutoFlush = 1 hack enabled?

gregory38 commented 8 years ago

@vortexofdoom And does it work better with Zerogs (or zzogl)

pipyui commented 8 years ago

No luck with UserHacks_AutoFlush = 1 nor ZeroGS.

I would note that when hardware rendering with GSdx OpenGL, UI displays just as software mode when 'Preload Frame Data' is configured in 'Configure Hacks', but only when emulator is started so configured and remains uninterrupted by configurations or switch to/from software render.

gregory38 commented 8 years ago

The HW renderer is likely a texture cache issue. Hum, could be a wrong palette.

pipyui commented 8 years ago

If it helps, the UI elements don't disappear after render switch, but all seem to get misplaced into the top corner, while also apparently failing to reflect any information. I've screenshots in this post (wasn't running an official git build at time of post, but have since been).

gregory38 commented 7 years ago

Hw renderer is a texture cache issue. I got a depth buffer instead of the real input texture.

I also noticed some invalid PSM format for the framebuffer. In this case GSdx will skip the draw call. I try to replace the invalid format with a valid one. Rendering is a bit better but I got some strange triangle. broken_hud

Maybe there is a also core bug. I don't know.

gregory38 commented 7 years ago

I potentially have a fix for the HW renderer. But main issue still exists.

gregory38 commented 7 years ago

Be happy I found the crazyness.

MarcoEstevez commented 7 years ago

How epic are you :)

gregory38 commented 7 years ago

Honestly on this one, I deserve a very good :beer: => #1605

gregory38 commented 7 years ago

For the posterity berserk

gregory38 commented 7 years ago

I pushed the frame format fix. So you can play the game properly on the SW renderer. I still have a pending fix on the pull request for the HW renderer.

Illynir commented 7 years ago

On HW, all UI disappeared now except health boss and minimap.

Cutscene subtitle doesn't appear before and after commit on HW also. Is it the same kind of problem ?

gregory38 commented 7 years ago
I still have a pending fix on the pull request for the HW renderer.

https://ci.appveyor.com/project/gregory38/pcsx2/build/1.1906-master/job/dvu2dypdafj6rirl/artifacts

Illynir commented 7 years ago

Yes i know. It was mainly to note the subtitle problem on video, if that was the same kind of problem.

gregory38 commented 7 years ago

maybe you can test the build on the previous post link ;)

Illynir commented 7 years ago

On that build, i have no UI and no subtitle on HW also.

I missed something ?

Omusoru commented 7 years ago

With the build you provided above the UI does indeed show up in HW mode but not the subtitles from cinematics. They still only show up in SW.

gregory38 commented 7 years ago

@Omusoru could you provide me a gs dump of those subtitle.

Omusoru commented 7 years ago

@gregory38 berserk_gsdump.zip I made one in HW and one in SW

gregory38 commented 7 years ago

Good news, I found the code that remove the subtitle. The bad new it is the same code that show the video... Ok I understand what happen.

It is a very complex topic.

Illynir commented 7 years ago

Ok, i understand my problem. On that build, there have no SSE4 version of GSDX, I was always on old GSDX plugin in SSE4 then...

I used SSE2 version of that build and UI works perfectly. :)

willkuer commented 7 years ago

so there is a difference between the sse4.1 and sse2 plugin of the same revision?

You just put all revisions into one folder assuming the sse4.1 plugin is overwritten but it wasn't as there was no unstable sse4.1 plugin and, thus, you tested an old revision?

Illynir commented 7 years ago

Yes i always overwrite files in one folder, but the build provided here don't have SSE4 version of GSDX that i usually use, then i used wrong version...

it's my fault, I'll be more careful next time. :)

At least I was able to highlight the problem of subtitles. :p

psennermann commented 7 years ago

Since a proper fix for the subtitles seems very hard to find, wouldn't it be possible to have at least an automatic game fix (CRC hack?) that enables for this game the software rendering option for FMV, instead of having always to enable it manually in the GameFix menu? (with this option enabled subtitles would show up not only in movies, but also in the game-engine rendered cut-scenes)...

gregory38 commented 7 years ago

Did you actually test the fmv hack option?

psennermann commented 7 years ago

Yes, I've seen that this option shows subtitles (automatically changes to software mode) for the opening movie and also for the first game-engine rendered cut-scene (the one where the snow monsters come out), then when game starts it switches back to hardware mode...

seta-san commented 1 year ago

this seems to be fixed. software fmv fix can be removed and i'm not sure what preload frame data was doing. the FMVs and UI look good in hardware with automatic fixes off. just need the upscaling fix now.

Mrlinkwii commented 1 year ago

The game has SW fmv , the game needs checked without this

seta-san commented 1 year ago

The game has SW fmv , the game needs checked without this

I did. The subtitles still show in hardware mode