search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.61k stars 1.6k forks source link

Meta: GSdx HW mipmap support #1561

Open gregory38 opened 8 years ago

gregory38 commented 8 years ago

Let's collect games that suffer from lack of mipmap. It would allow to avoid multiple bugs reports and easily see which games are impacted (and how many too).

Active issues:

Active issues, but not broken without mipmapping:

Fixed with automatic mipmapping option, but missing CRCs:

Fixed with automatic mipmapping option:

refractionpcsx2 commented 8 years ago

Wow, good job gregory!

Dreadmoth commented 8 years ago

Will check it out once the automated build finishes :)

I'm making a PR for something else that might improve R&C... EDIT: https://github.com/PCSX2/pcsx2/pull/1587

MrCK1 commented 8 years ago

@Dreadmoth It's done now. I imagine the patience is killing you 😃

Jak 3 looks awesome, besides the rainbow hair :P

gsdx_20160924132751

gregory38 commented 8 years ago

@willkuer I started thursday night. Nothing was working, Friday I remembered the offset trick. It was the initial version that I pushed. But actually, I think about it a long time ago.

The remaining issue of RC is potentially a rounding issue to select the good layer. And it seems ace combat is still broken.

woj1993 commented 8 years ago

Tribes: Aerial Assault is perfect.

prafullpcsx2 commented 8 years ago

Cricket games are almost perfect now, ICO rays are visible in intro (should be ingame too), Harry Potter Half Blood Prince is looking exactly like Sw mode, Fifa 2003 is also very good (suffers from other separate issue), Jurassic Park also looks much better. Awesome work gregory. :100:

MrCK1 commented 8 years ago

HSG4/Everybody's Golf works OK. Tree and ground textures get corrupted based on camera angle

gregory38 commented 8 years ago

I pushed a new fix. It would avoid issue with camera angle or some distance. My R&C dump is really nice now.

Nobbs66 commented 8 years ago

Gregory, will you marry me? I f'ing love you for this!

FlatOutPS2 commented 8 years ago

Jak II - mipmapping went from worse than no mipmapping earlier today to 1:1 with software mode now! :-O :+1:

It did notice a small issue, but it's the same on SW mode and might be on real console to, because it's not that noticeable on native res.

Ace Combat 4 has improved, but still has flashes of the broken graphics and I got a crash...

Dreadmoth commented 8 years ago

Very nice :+1: nice Some textures (seems to be mostly smaller objects?) still pop as you move around or if you stand in specific places - but the majority look correct from almost all angles.

EDIT: Same applies to Jak 3 ^, however the ground is affected more than in R&C

Tribes: Aerial Assault seems to be pretty much perfect

FlatOutPS2 commented 8 years ago

I got noticed a gap between textures in Ace Combat when close to the ground. Here's a GS dump: Ace Combat textures close up big black gap.zip

prafullpcsx2 commented 8 years ago

@gregory38 : It looks like Jurassic Park got a little worse ingame with your latest commit. Here is a gsdump. I believe it may be suffering from some other issues too.

jurassic park.zip

refractionpcsx2 commented 8 years ago

Just tried R&C, the game runs extremely well! But still a bit of glitching, i think it's when it's changing mipmap. There's also a bunch of SPS in the menu which is odd.

What's more annoying, if you're recording a GS Dump of the SPS in the menu. it stops! If i hold down Shift, Ctrl and F8, I don't get any glitching or SPS... Explain that one :P

Destroy All Humans is about at the same point, mostly fixed but some glitching/flicker of textures. Difficult to see it all as the lighting is still messed up leaving a ragged shadow over the screen.

Dokman commented 8 years ago

gsdx_20160925021235 This is my case with my R&C copy so... i cannot zip the gs file... Github don't want to get it... PS: i can upload it to mega is in 7z https://mega.nz/#!s4lwTI6D!5fn8QtlQgoiI803LaVehdPLoZFZSydhTL1l-2nYFORc

refractionpcsx2 commented 8 years ago

@Dokman you need to put the UserHacks_mipmap = 1 in your gsdx.ini file, then make sure mipmapping is enabled for sw mode, that looks like you haven't done that.

Dokman commented 8 years ago

okay let me see hahaha Okay sorry my fault with my new compiled binary of pcsx2

Dokman commented 8 years ago

okay let me tell you now how i watch it gsdx_20160925022750

my gs dump https://mega.nz/#!0tFVzCCa!gfhkkVVdNSFWkZrkjE1G4l-2lPImnGvdf1lb3LT_7O0

refractionpcsx2 commented 8 years ago

Hmm, are you using an old version or something? Because that looks like how it always looked (or close), but it looks pretty much fine mine with the newest git build.

Dokman commented 8 years ago

i have the latest build with yor pr for R&C and Jak image

refractionpcsx2 commented 8 years ago

can you try the master branch?

Dokman commented 8 years ago

i tried it in another binary and i have the same problems image

refractionpcsx2 commented 8 years ago

and you definitely have the right gsdx dll selected, not an old one?

Dokman commented 8 years ago

it's compiled by a new clone of the code so i think yes hahahaha image

refractionpcsx2 commented 8 years ago

Then that's very strange because it's fine here! :S

Dokman commented 8 years ago

with autoflush works but i have a a worst performance i have like 10 fps or 15

refractionpcsx2 commented 8 years ago

Hmm, I have autoflush off.

Dokman commented 8 years ago

idk what is happening hahahaha

Dreadmoth commented 8 years ago

@Dokman Maybe try the AppVeyor build of the framebuffer shader PR ?

With that build and UserHacks_mipmap=1 added to gsdx.ini, Ratchet & Clank looks like this for me (using these GSDX settings).

Dokman commented 8 years ago

what hacks you have set for r&c? PS: i have this i set auto flush

Dreadmoth commented 8 years ago

Nothing enabled in the menu - the "Enable HW Hacks" checkbox must be checked for the UserHacks_mipmap=1 ini setting to apply

refractionpcsx2 commented 8 years ago

I just have fast invalidation enabled, nothing else

Dokman commented 8 years ago

thanks hahah i don't know that

Sarania commented 8 years ago

Just FYI it doesn't seem to work for me either. I'm using the latest build, HW hacks enabled, UserHacks_mipmap=1 in gsdx.ini.

Edit: Take that back. It does look some better but still pretty damned nasty.

Dokman commented 8 years ago

in my case R&C 1 is like perfect, not perfect but it's playable, it has a lot of stuttering but is playable

AmbientMalice commented 8 years ago

Deus Ex makes heavy use of mipmapping. Without the hack, the game looks fine, if a bit shimmery. With the hack enabled, everything breaks.

gsdx_20160925165046

gsdx_20160925165133

gregory38 commented 8 years ago

On the option, I think you could use the keyboard shortcut. The hack ought to be the start/default value only.

Otherwise, code is quite new. Please don't expect too much. I'm not even sure, if it could really work. Remember it is hack not a full implementation.

Just tried R&C, the game runs extremely well! But still a bit of glitching, i think it's when it's changing mipmap. There's also a bunch of SPS in the menu which is odd.

What's more annoying, if you're recording a GS Dump of the SPS in the menu. it stops! If i hold down Shift, Ctrl and F8, I don't get any glitching or SPS... Explain that one :P

@refractionpcsx2 I think there are potentially texture cache issue too for this game. On the mipmap layer. My hack only loads a single layer. Potential issue

mirh commented 8 years ago

Ok I finally realized this is what you really need to enable mipmapping

mipmap=1
UserHacks=1
UserHacks_mipmap=1

Indeed Ace Combat 5 improves in the distance (while nearest part of the terrain is still kind of glitchy)

prafullpcsx2 commented 8 years ago

@gregory38 : Did you had a look at jurassic park dump I attached above? Is it suffering from only mip map issue or something else is also there?

gregory38 commented 8 years ago

Quick look. Even sw render got some difficulties to replay the dump. There are likely others issues in the mix. I'm still trying to understand how to proper round the mess.

Sarania commented 8 years ago

With latest fixes R&C3 is working near flawless for me now, so ignore my previous message.

Edit: Actually all three are :) And I get full speed in DX11 mode :)

Dokman commented 8 years ago

@gregory38 i have a 4790K @ 4,4Ghz and i can't play with a good fps rate in R&C 1, why is happenning? i have set the preset to Agressive

Dreadmoth commented 8 years ago

@Dokman Strange, R&C 1 runs full-speed (aside from the in-game menu) using the settings I posted earlier on my 4770 @ 3.4GHz and GTX 770 - what settings / speedhacks are you using? I have EE Cyclerate and VU Cycle Stealing at 0, all other speedhacks enabled. (setting EE Cyclerate to negative values and/or VU Cycle Stealing to anything above 0 seems to result in reduced "true" FPS - making the game feel very sluggish even at "full speed")

Dokman commented 8 years ago

okay i will see later

FlatOutPS2 commented 8 years ago

Just set the preset back to Safe, and make sure the MTVU speedhack is still enabled.

gregory38 commented 8 years ago

maybe we could open a forum thread for mipmap support. So this issue tracker doesn't explode.

By the way, Legacy of kain is much better except when the erratic gliches when you change the camera angle

Dokman commented 8 years ago

eith dx11 it works at full speed

Sarania commented 8 years ago

@gregory38 - I will make the thread now, once sec.

Edit, done: http://forums.pcsx2.net/Thread-New-feature-Needs-testing-GSdx-HW-mode-Experimental-mipmap-support

FlatOutPS2 commented 8 years ago

By the way, Legacy of kain is much better except when the erratic gliches when you change the camera angle

The same goes for most other games. If you move the camera you can often see (part of) the mipmapping glitches pop back in.

gregory38 commented 8 years ago

Yes Need some tuning. Does the glitches remain if you stop moving on the bad angle ? I need to capture it in a gs dump to understand what going on.