search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.45k stars 1.59k forks source link

Meta: GS SW issue #1562

Open gregory38 opened 8 years ago

gregory38 commented 8 years ago

Single issue report to centralize all current issue/limitation with the SW renderer. The trick is to avoid core bug.

Active (as of March 2019):

Resolved before or in 2017:

FlatOutPS2 commented 8 years ago

Might be core issue, but potentially GSdx issue: http://forums.pcsx2.net/Thread-Smackdown-4-Shut-Your-Mouth-special-meter-doesn-t-display-properly

Alpine Racer 3. GSdx issue that also affects SW, there's a CRC hack for HW mode. Without the CRC hack DX11 HW is playable, but DX9 HW, OGL HW and SW modes are covered in black.

Colin McRae Rally 2005: Game looks way too bright in SW mode: https://github.com/PCSX2/pcsx2/issues/1546

TheLastRar commented 8 years ago

Network Profile Wizard (the one built-in with some games), Most text/boxes stuck in top left. I believe this is a GS emulation issue rather than a core issue. https://github.com/PCSX2/pcsx2/issues/287

FlatOutPS2 commented 7 years ago

Colin McRae Rally 2005 Software mode issue has been resolved thanks to https://github.com/PCSX2/pcsx2/commit/3994141d4085c6365876efc0c561893cda9aba96

gregory38 commented 7 years ago

We need to add the jak issue and the explanation in this report.

prafullpcsx2 commented 7 years ago

Although it wasn't mentioned in this thread but I would like to report that software mode ghosting in Catwoman is also fixed by auto flush hack. HW mode ghosting is same as before.

gregory38 commented 7 years ago

Good, I wanted to ask you :+1:

MonJamp commented 7 years ago

@gregory38 The cutscenes in Thrillville are cut off even in SW mode. Can you confirm if this is a core bug? There's a GS dump in this forum thread: http://forums.pcsx2.net/Thread-Bug-Report-Thrillville-NTSC-U

gregory38 commented 7 years ago

@monsterjamp did you test zerogs? Honestly a partial texture upload is likely a core bug.

MonJamp commented 7 years ago

ZeroGS keeps crashing when it gets to the cutscenes so I can't test it.

There's also another issue but this one is only present is SW mode. In the pause menu, the bottom right of the screen is missing.

Hardware mode: 2016-10-06 13_11_43-slot_ 0 _ speed_ 101 60 36 _ limiter_ normal _ gsdx d3d11 hw _ 640x445 _ bob

Software mode: 2016-10-06 13_12_11-slot_ 0 _ speed_ 84 50 26 _ limiter_ normal _ gsdx d3d11 sw _ 640x445 _ bob

GS dump: http://www.mediafire.com/file/r9b2xgcypbua50q/gsdx_20161006131227.gs

Maybe I should open up an issue?

FlatOutPS2 commented 7 years ago

There's text missing in Pride FC menu's in HW and SW modes. Could be a GSdx issue, here's a GSdump:

Pride FC missing text.zip

FlatOutPS2 commented 7 years ago

Burnout 3 still has missing flags in OGL hardware and software modes. The flags can only be seen with the Direct3D HW renderers(see the 3 grey flags in the added screenshot). The flags are not supposed to be grey, but colored American flags.

Burnout 3 missing flags SW and HW.zip

gregory38 commented 7 years ago

I just found that GS local memory can wrap around. It explains a bug on Silent Hill 3 FMV. I think it can potentially explain issue on Thrillville. Potentially the end of the FMV is the start of the memory. My guess is that HW will happily overflow the frame buffer whereas SW will hit a wall.

gregory38 commented 7 years ago

If you use Linux, you can use the new hidden option wrap_gs_mem = 1 in gsdx.ini. I advice to use it only for the SW renderer.

gregory38 commented 7 years ago

I gave a look at Thrillville the issue is very close but my option doesn't fix it. The game does some rendering at 0x3C00 which means only 32 pages remain. The rendering is 320x224 so 5*7 pages. It overflows 3 pages (which are the bottom black area)

Edit: yeah, the framebuffer is good now but it is need to be translated as an input texture which is bad. There are various code that stop at the end of the memory. I removed a couple of them and the FMV start to appear (but color is wrong, so there is likely various bugs).

gregory38 commented 7 years ago

@monsterjamp I pushed some fixes for Thrillville, the only requirement is a linux OS.

gregory38 commented 7 years ago

@monsterjamp I pushed some improvements that should work on Windows too (without the option)

FlatOutPS2 commented 7 years ago

So the option is useless now?

gregory38 commented 7 years ago

I keep it for debug purpose but it ought to work without it. The wrapping is limited to a couple of key functions.

FlatOutPS2 commented 7 years ago

Yes, the latest master works with SH3 FMV in Software mode with default settings. Now we only need to confirm it works with Thrillville as well.

gregory38 commented 7 years ago

1628 still not clear of the current status

FlatOutPS2 commented 7 years ago

In ATV Quad Power Racing 2 AI controlled quads are missing or appear as a bugged texture in Software mode. They're fine in Hardware mode.

GSDump(rename .pdf to .zip) ATV Quad Power Racing 2 - missing AI quads in SW.pdf

MrCK1 commented 7 years ago

I finally got Nascar 09 working - it needed EE Cache to boot. There's something going on with the screen height and all 3 renderers crash in SW mode. Would a GSDump in HW renderer be useful?

(The screenshot is too "long" to paste here so here it is :P)

prafullpcsx2 commented 7 years ago

@MrCK1 : Can you please check whether it works with eecache before https://github.com/PCSX2/pcsx2/commit/49b80a4916580838375faf4698a336e898648c6b

MrCK1 commented 7 years ago

@prafullpcsx2 I just checked and it doesn't work before that point

BTW, it only needed ee cache to boot. After that I can load from a save state/switch to recompiler

FlatOutPS2 commented 7 years ago

And another software mode issue: http://forums.pcsx2.net/Thread-GSDX-Software-mode-Bug-Report-Arc-The-Lad-End-Of-Darkness-Graphical-glitch

FlatOutPS2 commented 7 years ago

Alpine Racer 3 issue has been resolved. Quick test indicates it was fixed by the Berserk 8/4 bits commits.

I believe there's still a CRC hack for this game, which can now also be removed.

MrCK1 commented 7 years ago

Quick question - is it normal for FMVs in SW mode to "bleed" at the bottom of the screen? I've noticed a few games have this.

gsdx_20170103173031

FlatOutPS2 commented 7 years ago

No. Is the bottom of the screen black in Hardware mode or does Hardware mode use the full screen?

MrCK1 commented 7 years ago

No, hardware mode is fine. In the two cases I tested, they both fill the entire screen.

EDIT: Found the regression. It was introduced in #1683.

Here's a GS Dump as well. (Rename to .7z)

HW: gsdx_20170103183414

FlatOutPS2 commented 7 years ago

EDIT: Found the regression. It was introduced in #1683.

That makes sense. @ssakash already made a PR to fix these issues: https://github.com/PCSX2/pcsx2/pull/1693 It fixes the dump, but be sure to try the PR with the other games you've noticed have the issue just in case.

MrCK1 commented 7 years ago

Looks good to me so far. 👍

gregory38 commented 7 years ago

Looking at the into of SotC, it seems to have bad texture when mipmap is enabled (mountain). Could someone confirm it, and tell me if it is a regression/known problem/..

FlatOutPS2 commented 7 years ago

Smash Court Tennis Pro Tournament has a Software mode issue(it's fine with HW renderers) http://forums.pcsx2.net/Thread-Bug-Report-Smash-Court-Tennis-Pro-Tournament-USA And this is also likely a GSdx issue(it's worse in OpenGL HW than any other renderers, but also affects SW): https://github.com/PCSX2/pcsx2/issues/983

gregory38 commented 7 years ago

We need some volunteers to test #1843 :+1: So far it fixes Jak3 and Xenosaga issue. But it could explain some others bugs.

And I need a confirmation that #84 still contains some SW bugs. If yes, it need to be added on the list.

MrCK1 commented 7 years ago

Guess I forgot to mention earlier that "The Suffering: Ties that Bind" can be added here. Check the most recent post in #1774 for details.

gregory38 commented 7 years ago

@FlatOutPS2 The PR #1843 seems to fix Smash Court Tennis Pro Tournament screenshot - 03052017 - 06 32 34 pm

Are those issues SW only ? Do we have a gs dump for them ?

FlatOutPS2 commented 7 years ago

The Arc The Lad: End Of Darkness gsdump is included in the thread I linked: http://forums.pcsx2.net/Thread-GSDX-Software-mode-Bug-Report-Arc-The-Lad-End-Of-Darkness-Graphical-glitch

gregory38 commented 7 years ago

Ok. ATV seems to be fine with the PR too. At least when I replay multiple time the dump, quads appear :)

gregory38 commented 7 years ago

@FlatOutPS2 the dump expired.

ATV testcase is really interesting. My new code is working due to luck.

FlatOutPS2 commented 7 years ago

Arc The Lad: End Of Darkness gs dump: Arc End Of Darkness - triangle icon partially hidden in SW mode.zip

Isn't luck also the reason why several other games have been fixed by that PR? :p

gregory38 commented 7 years ago

Nah I did my homework. I pushed a one line fix on master that fix a bad optimization. Hopefully it will fix multiple games.

gregory38 commented 7 years ago

Holy cow, Arc is still broken. If you heard someone screamed, it was me :(

Edit however my log is interesting.

T:Oth   ID:542  S:Cache => TC depth: dst Depth hit: 4 (0x1c00, BAD_PSM)
gregory38 commented 7 years ago

It is a depth issue. I'm surprised that the HW render is kind of working. Depth of the triangles of the ballon ranges from 0x7FFFFFF6 to 0x7FFFFFF7. But looking at the depth buffer, I can 0x80000000 values written. (draw call 547 of the dump) The cursor uses 0x7FFFFFF6 as depth value. (draw call 548 of the dump)

Maybe we need to round somewhere the depth. But I'm afraid it can't be fixed.

gregory38 commented 7 years ago

Does anyone manage to reproduce the Zone of Ender issue. Report is quite old.

FlatOutPS2 commented 7 years ago

Does anyone manage to reproduce the Zone of Ender issue. Report is quite old.

The included dump still shows the issue with recent PCSX2 builds.

gregory38 commented 7 years ago

@FlatOutPS2 Any particular setting ?

FlatOutPS2 commented 7 years ago

No, just the default.

gregory38 commented 7 years ago

I don't see it. There is a light flickering but nothing more.

gregory38 commented 7 years ago

@FlatOutPS2 could you quickly test the PR for blood will tell. Maybe it is the same kind of bug. Or do you have it without any extra rendering thread.

FlatOutPS2 commented 7 years ago

I see the patterns from the image in the bug report with all Software renderers, with or without extra renderering threads. Hardware mode is fine.