Closed Byrkoet closed 2 years ago
I've tested Jak 3 on build 1.5.0-3391, which should be indicitive of performance on the final 1.6.0 release (running on a Ryzen 2400G and a GTX 1060 6GB, at least)
Shadows are 90% fixed in both DX11 and OGL, Eyes are 100% fixed, however DX11 performance is abysmal, while OGL performance is fantastic. The GPU is definitely the bottleneck, I'm able to run at 4x internal resolution scale smoothly on OpenGL with my 1060, but I can barely keep up 60fps at native on DX11.
@yiays You can eliminate those shadow issues - use OpenGL (Hardware), set Blending Accuracy to Basic (or higher) and disable the Auto Flush hack. The Auto Flush hack may also be contributing to the DX11 performance issue (but is necessary for decent shadows on that renderer).
Yep, you're spot on. The auto flush hack causes the unusual shadows in OpenGL, and causes the terrible performance in DX11.
Maybe we can do if auto flush on, disable the blending code for jak shadows. Need to ask Greg.
Auto flush will do a full GS draw by primitive. I.e. we will do a texture cache lookup and downscaling (hence the no pixel perfect rendering of the shadow).
Blending will render primitive by primitive at the GL level. So we skip the expensive texture cache. And we could work at the upscaled resolution hence the better shadow.
@yiays I have an AMD GPU (RX 580), so I couldn't use OpenGL, so I fixed the shadow problem using Skipdraw Range at 1.
any update in this?
Update: Within the last couple months, a regression has been fixed in Jak X, and another issue which I don't believe was a regression has seemingly become more limited in scope. Both of these relate to texture corruption. Using latest dev version with D3D11 and OpenGL renderers; tested at both native resolution and 3x (1080p).
Regression fixed: In Jak X, the wheels had corrupted, greenish textures, especially prominent when the car is moving. Having looked at all 15 wheel types, this is no longer an issue.
Other "fix" (can't tell, but it seems like it): there was a texture corruption issue in Jak X which corrupted the paneling textures on certain panels of certain vehicles. I can't recall exactly which parts and which vehicles, but as of right now, the only two corruptions are on the rear fender of the Howler 99 (no matter which fender style you choose) and the roof panel on the Boomer (no matter which roof panel style you choose). The software renderer eliminates both of these, but they are both present on both hardware renderers.
Update: Within the last couple months, a regression has been fixed in Jak X, and another issue which I don't believe was a regression has seemingly become more limited in scope. Both of these relate to texture corruption. Using latest dev version with D3D11 and OpenGL renderers; tested at both native resolution and 3x (1080p).
* Regression fixed: In Jak X, the wheels had corrupted, greenish textures, especially prominent when the car is moving. Having looked at all 15 wheel types, this is no longer an issue. * Other "fix" (can't tell, but it seems like it): there was a texture corruption issue in Jak X which corrupted the paneling textures on certain panels of certain vehicles. I can't recall exactly which parts and which vehicles, but as of right now, the only two corruptions are on the rear fender of the Howler 99 (no matter which fender style you choose) and the roof panel on the Boomer (no matter which roof panel style you choose). The software renderer eliminates both of these, but they are both present on both hardware renderers.
With the 1.7.0 and1.7.2 daily updates (1.7.2260) the green corrupted textures have resurfaced and an intermittent short freezing seems to happen on all hardware renderers, NTSC and PAL copies
Update: editing this as I go through the game again only certain wheels affected,
I have marked this as fixed by #5580 as the textures and shadows are perfect as of that. However the SW mode regression is still a thing, we're aware of it and I have passed it on to the people who are concerned.
Thanks for the reply
Very coincidental timing.... I just booted up jak 3 for the first time since posting this pretty much the minute before I got this email. Nearly everything seems to be fixed by using vulkan and ee 130% in 1.7.24 nightly. you guys are all doing a great job.
I still have some minor bugs if you want a detailed submission
Stephen
On Sat 5 Mar 2022, 14:40 refractionpcsx2, @.***> wrote:
I have marked this as fixed by #5580 https://github.com/PCSX2/pcsx2/pull/5580 as the textures and shadows are perfect as of that. However the SW mode regression is still a thing, we're aware of it and I have passed it on to the people who are concerned.
— Reply to this email directly, view it on GitHub https://github.com/PCSX2/pcsx2/issues/168#issuecomment-1059776364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGB26GN75T4V26IYPKODOVLU6NW7NANCNFSM4ASE3XJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
yes please, saying "Minor bugs" doesn't really helps us fix anything.
and GS dumps would be helpful too
Alright, ill get back in a few hours with details I just didnt want to load one email with multiple different topics
On Sat 5 Mar 2022, 15:43 refractionpcsx2, @.***> wrote:
yes, saying "Minor bugs" doesn't really helps us fix anything.
— Reply to this email directly, view it on GitHub https://github.com/PCSX2/pcsx2/issues/168#issuecomment-1059785347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGB26GIW3KEVA24S5YTTL7LU6N6JTANCNFSM4ASE3XJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
-PCSX2 version: 1.2.1.r5873 - compiled on Feb 3 2014
-PCSX2 options: Defaults, no settings modifications affect the issue.
-Plugins used:
-Plugin settings: Tested GSdx DX9/11 hardware; DX11 seems to make things worse by having more of an impact. SkipDraw 1 used to remove player shadow altogether.
-Description: Basically, most textures are corrupted. One great example is the right eye of most characters (also an issue in previous installments of the game).
-How to replicate: Boot the game and enjoy the black-textured landscape and corrupted eyes and miscellaneous objects.
-Last known version to work: Unknown, probably never worked.
-PC specifications: CPU:
-Other comments: The graphical corruption, including the missing eye(s), is also present in previous installments, including, but not limited to Jak and Daxter (SCUS97558 & SCUS97124).