PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.83k stars 1.63k forks source link

GameDB improvement and missing patch files #1976

Closed ghost closed 7 years ago

ghost commented 7 years ago

image

MrCK1 commented 7 years ago

Is there a valid reason for these improvements? (Ie. Are they documented in the forums, ect.)

lightningterror commented 7 years ago

Apparently there is for Max Payne. http://forums.pcsx2.net/Thread-Max-Payne-SLES-50325-E--29333

As for R&C is he talking about Going Commando?

Anyway here is the modified GameDB. Anyone care to test this out ? Don't wanna make a pr yet. https://drive.google.com/open?id=0B8cQAq-Ko9-ueWpZOFp0TEVIWWM

ghost commented 7 years ago

Yes its Ratchet and Clank Going Commando (Ratchet and Clank 2 in my country).

ghost commented 7 years ago

Your GameDB work and solved these games but missing patch are not also added.

lightningterror commented 7 years ago

@ssakash , @MrCK1 I didn't add the VU I bit hack since i don't see it in the dbf file mentioning that it can be added. Can it still be added with just adding "ScarfaceIbit = 1" ? Or other changes need to be done first before it can be used here?

ghost commented 7 years ago

Oups , i have forget to added Metal gear solid 3 (all versions): VUs :Clamping mode , extra + preserv sign

lightningterror commented 7 years ago

Metal Gear Solid 3 Subsistence or Metal Gear Solid 3 Snake Eater ?

http://forums.pcsx2.net/Thread-Metal-Gear-Solid-3-Snake-Eater-SLES-82013-E--30514 It seems for Snake Eater the values shouldn't be changed since it was tested.

Also are you using the latest dev build ?

ghost commented 7 years ago

I have used the 1.4.0 and the latest build but in this game , its strange because , if Clamping mode is set to Normal or never , it will cause many artefacts on screen in both versions.

ssakash commented 7 years ago

Can it still be added with just adding "ScarfaceIbit = 1" ? Or other changes need to be done first before it can be used here?

It's actually ScarfaceIbitHack and yes, it'll work without doing any other internal change in the codebase.

ghost commented 7 years ago

For MGS3 Screen artefacts is reduce on latest build but still here.

lightningterror commented 7 years ago

What about the other games , did you test them with the latest dev build as well?

Edit: I'm still confused what you mean about MGS3 , Is it Subsistence or Snake Eater also pal or ntcs or both ?

ghost commented 7 years ago

for mgs 3 its all version , all games are tested with both versions (1.4.0 and last build) and all games have issues on both versions.

ghost commented 7 years ago

And Mercenaries 2 World in flames dont have the patch in frensh version

ghost commented 7 years ago

The frensh version is named :Bratz - the movie. , the hack is EE timing hack.

ghost commented 7 years ago

This is the comment of the patch for Mercenaries 2 ://flickery textures

lightningterror commented 7 years ago

Mercenaries 2 seems to have ee timings fixes already.

ghost commented 7 years ago

Yes but not the frensh version wich is named Bratz - the movie

ghost commented 7 years ago

To be precise , all version have the hack but the frensh version dont have.

lightningterror commented 7 years ago

Can you tell me the serials of MGS3 that you have , also for Mercenaries 2 because "Bratz - the movie" seems to be an entirely different game.

ghost commented 7 years ago

The serial of mgs 3 is : SLES 82042 - 82043 -82050 (the subsistence frensh version) and Bratz - the movie is probably an error in the GameDB beaucause the real name is Mercenaries 2 L'enfer des favelas.

ghost commented 7 years ago

For Mercenaries 2 its : SES 54998

ghost commented 7 years ago

SLES

lightningterror commented 7 years ago

Great , just for safety can you tell me the serials for the other games? Ratchet and Clank 2 (pal) Rayman revolution (pal) Max payne (all versions)

ghost commented 7 years ago

For ratchet and clank 2 its : SCES 51607/p (platinum version) , for rayman revolution its : SLES 50044 and Max payne is : SLES 50326 (Note: I had say all version for Max Payne because i saw many post That tallk to the issues).

lightningterror commented 7 years ago

https://drive.google.com/open?id=0B8cQAq-Ko9-uVEdrV3FPMVRzcFk

Please test this out. Also re test Max Payne , I added the missing Vu I bit hack.

ghost commented 7 years ago

everything works great ! Its a great improvement.

ghost commented 7 years ago

Max Payne is now very stable and playable also , we can close the #964 issue

lightningterror commented 7 years ago

I wouldn't recommend closing that , this is just a workaround. When the issues are fixed with the emulation itself without needing any gamefixes it can be closed.

I'll make a PR soon since latest dev builds don't have these fixes.

ghost commented 7 years ago

And Mercenaries 2 frensh issue in now corrected!

ghost commented 7 years ago

Ok

lightningterror commented 7 years ago

One final test , can you test again with this version ? Just minor edits and stuff before the pr. https://drive.google.com/open?id=0B8cQAq-Ko9-ueGV3NmZGWDdHVjg

ghost commented 7 years ago

Everyphing is OK wee can PR

mirh commented 7 years ago

When the issues are fixed with the emulation itself without needing any gamefixes it can be closed.

Mhh not sure there ever was this rule. I mean, if any there could be a "master" tracker issue, but anything more is just madness imo.


Anyway, I see hacks actually supported are 17 For some reason gameindex only mentions 15

lightningterror commented 7 years ago

Mhh not sure there ever was this rule.

I'm just recommending since it's not actually fixed. I'm fine with it if it's closed.

Anyway, I see hacks actually supported are 17 For some reason gameindex only mentions 15

Maybe they weren't used , I did add the "ScarfaceIbitHack" tho so that's 16 if we count the PR.

lightningterror commented 7 years ago

@atomic83GitHub I forgot to ask but can you tell me what each gamefix does on Max Payne? I'd like to add a bit more information as to what each does in the PR.

ghost commented 7 years ago

Each gamefix avoid randomly crash and stability of the game.