Update mesa blacklist - Githubissues

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator

https://pcsx2.net

GNU General Public License v3.0

11.8k stars 1.63k forks source link

Update mesa blacklist #2025

Closed mirh closed 6 years ago

mirh commented 7 years ago

https://github.com/PCSX2/pcsx2/blob/6589feaacdff52b0dfcca57bb2107c3fcf70d051/plugins/GSdx/GLLoader.cpp#L275

https://mesamatrix.net/ I'm not sure there's an easy mechanism to distinguish between r600/radeonsi or nv50/nvc0 - but if not any core GL spec could be checked (for say, >4.1 or <4.5)

Fixes this

gregory38 commented 7 years ago

You mean in 1.4 branch ? Because it doesn't impact any code.

It could also be a true Mesa bug.

mirh commented 7 years ago

Buggy driver detected. Geometry shaders will be disabled Buggy driver detected, GL_ARB_separate_shader_objects will be disabled

That seems some code impact.

gregory38 commented 7 years ago

I mean in current GIT. And it must work without those extensions (it's only impact speed).

mirh commented 7 years ago

@Also, the comments a bit above

found_GL_ARB_clear_texture || GL_ARB_draw_buffers_blend

Seems supported by every driver. Not sure if Dx10 class gpu still have it and you want to note (at least 10.1 does)

GL_ARB_shader_image_load_store

~~Wired to Fermi+ and GCN+~~

gregory38 commented 7 years ago

Those comments are a bit outdated. There were extracted from Mesa code. Anyway, it isn't important.

Oh by the way, I use both Mesa and Nvidia drivers. Maybe I should test a 1.4 build with Mesa.

gregory38 commented 7 years ago

As posted on the forum, it could be the GCC7 bug.

rcaridade145 commented 6 years ago

Does this make sense in 2018 considering the advances on Mesa? @gregory38

gregory38 commented 6 years ago

@rcaridade145 I don't think there is any blacklist for mesa on "recent" git version.

@mirh Could this bug be closed ? Or do you see a particular blacklist that should be removed ?

rcaridade145 commented 6 years ago

@gregory38 I think some blacklist so be in use because of this bug #2144 . A rx460 should be fast enough on mesa or amdgpu by now.

gregory38 commented 6 years ago

Reality is that

proprietary driver isn't good perf wise (even on windows)
Mesa misses some bits to improve threading on texture upload. See #1403

mirh commented 6 years ago

I'm a bit left wondering why I opened this, when 885ef7a46ffa7aee92d693563c0f1f30c0917c12 had already happened. Sorry? Closing.

Though, for the records, you could still improve comments I guess. GL_ARB_shader_image_load_store is now supported on every shader5 card GL_ARB_viewport_array is also supported by SB since https://github.com/mesa3d/mesa/commit/5fc23375e80dd2084f30700bdd3216082f662acc Last but not least, I guess like leveraging GL_ARB_texture_filter_anisotropic from open drivers might be neater?