PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.27k stars 1.57k forks source link

[GSdx] San Andreas Radiosity Broken - DX11 HW mode #2532

Closed davepalmeruk closed 6 years ago

davepalmeruk commented 6 years ago

Development build v1.5.2456 DX11 HW mode Internal resolution = x6 Anisotropic Filtering: 16x Safe preset MTVU speed hack Auto Flush HW hack enabled CRC Hack Level: Partial CRC = B440A8FE

DX11 HW mode on GS 1.1.0 has broken effects for GTA: SA.

With Auto Flush enabled, using None, Partial or Full CRC hack level, all display as if the skipdraw "3" hack is enforced despite being set to 0. Lighting, radiosity and blooms effects are missing. If using Partial CRC hack level the heat haze effect works fine though, so shows that some layer effects are OK.

DX11 HW mode - Partial CRC hack level. gsdx_20180731094457

GS dump of DX11 HW mode. gsdx_20180731094457.zip

To confirm it seemed to be within the plugin I copied GS v1.0.0 file from v1.4.0 and selected it in v1.5.0. As the auto Auto Flush hack isn't available shall ignore the known overlay issue, yet all lighting effects return along with the heat haze effect.

GS 1.0.0, DX11 HW - Same build, same options, no Auto Flush HW hack. image

Found issue whilst testing and comparing for #2525.

lightningterror commented 6 years ago

The game needs Hardware Depth on Direct3D which needs to be ported from OpenGL.

Duplicate of #2458

davepalmeruk commented 6 years ago

OK thanks @lightningterror for the update. Shall follow 2458. Can I confirm (simplistically I know) as it worked OK on GS plugin 1.0.0 yet there are no options to halt the previous overlay issues.

So my understanding is the change is caused by new code in 1.1.0 (which for example provides Auto Flush, mip-mapping etc) yet will in addition now need Hardware Depth to replicate the effects which worked before in GS 1.0.0 on DX11?

I'm just curious, still plan to use OpenGL as the better solution.