search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.67k stars 1.61k forks source link

GSdx Hack Tracking Thread #3568

Open tadanokojin opened 4 years ago

tadanokojin commented 4 years ago

We have many hacks. Many have been lost to time and their function is unknown. Others can be patched using out patching system rather than relying on CRC hacks. This is a thread dedicated to researching/replacing/working around GSdx CRC hacks.

Testers: Please provide before and after images for anything you notice different between CRC hack levels. Patch authors: Please attempt to replace any applicable CRC hacks with patches.

5/27/2024 - current issues:

Manhunt 2 Channel effect. Gamma correction similar to GT4 but page-based.

Big Mutha Truckers Skips an extra texture shuffle call

DBZ: BT3 Upscaling misalignment

Death By Degrees Broken shuffle effect, broken upscaling, possible broken channel effect, last hack unknown see: https://forums.pcsx2.net/Thread-GSDX-Texture-Cache-Bug-Report-Death-By-Degrees-SLUS-20934-NTSC

Ghost in The Shell Channel effect

Sacred Blaze Unknown. Listed a "rendering glitches"

Sakura Taisen/Sakura Wars Unknown.

Street Fighter EX3 Distortion/doubling

Burnout Games Yellow stripes from channel effect.

Midnight Club 3 Heavy vram usage

Tested: tokyo default cruise.
Move around a bit, stop car, wait as vram goes down, start moving again, vram spike.

Tekken 5 Aggressive hack to remove ghosting/blur on stages Moonfit Wilderness and Acid Rain. Hack appears to remove a channel effect. Black lines on stage Burning Temple.

Ultraman Fighting Evolution Aggressive hack for "blur"

Tales of Symphonia "Animated black screen to speed up the battle" and "Afterimage"

Simple 2000 Vol. 114 Aggressive hack to sort blur due to upscaling.

Stolen Channel effect.

Kunoichi/Nightshade Shadows/Blackscreen. Aggressive speedhack to remove blur effect. See #3988

Onimusha: Dawn of Dreams Aggressive hack. Mostly unknown. Fog related?

Sniper Elite Blur/ghosting even on native caused by channel effect.

Xenosaga "E3" Don't know if Xenosaga III or E3 Demo of Xenosaga I. Mostly unknown. Ghosting and post processing.

Sakura Taisen V/Sakura Wars: So Long, My Love Unknown. Hack says "removes darkness" and "floodlight".

Channel Shuffle Any games known to use channel shuffle can be patched to remove it as a speedhack.

------------------FIXED/PATCHED------------------------------------------

Star Ocean 3 Expensive emulated stencil. Hack no longer exists

Valkyrie Profile 2. Similar to Start Ocean 3. Hack no longer exists

Radiata Stories Similar to Star Ocean 3. Hack no longer exists

God Hand Unknown. Says "blur". Hack was purged

Urban Reign Broken shadow effect on rain see: #3375. Fixed by Tex in RT

God of War 2 Speed hack that removes shadows. Possible haze/upscaling issue. Upscaling issue on water.

Wild Arms Games Unknown. Appears to skip calls relating to to the color attachment PSM being Z32.

Crash: Wrath of the Cortex Channel effect

Shadow of Rome Depth related issue do to alpha extraction with 8H format. Grey wall. Last hack unknown.

Spartan Skips depth sampling. Channel effect.

Ikki Tousen/Battle Vixens Upscaling blur

Genji Listed as "blur" and "white fog". Additional DX only hack for shuffling, may not be needed. (TS, depth, blur)

Evangelion: Jo Aggressive hack to remove blur and ghosting

Onechanbara 2 Special Aggressive hack to remove upscaling issues

Time Splitters 2 Used to fix 4-player overlay in HW renderers. Hack removes some post procesing.

The Lord of the Rings: The Third Age Unknown. Appears to skip shadows.

Tomb Raider: Anniversary Garbage due to texture cache?

Bully Broken upscaling causing blur

Tomb Raider: Legend Similar to anniversary. Additional hack for black screen underwater.

Tales of Legendia Mostly unknown.

Zettai Zetsumei Toshi 2/Raw Danger Very expensive channel effect that is currently broken on hw rendering.

Fighting Beauty Wulong Aggressive hack to remove blur. Listed as similar to Tekken 5.

Knights of The Temple 2 "Ghosting" and "Light source"

Skygunner Vram usage

Steambot Chronicles Same as raw danger

Yakuza Games Aggressive hack for upscaling issues

Getaway Games "Fog wall"

Tenchu Games Fog wall related to blending?

Sly Cooper Games Upscaling issue due to channel effect.

Grandia 3 Blur

Ace Combat 4 Aggressive speedhack to remove clouds and blur from airplane.

Bleach Blade Battlers Aggressive speedhack to remove body shading.

God of War Aggressive speedhack to remove shadows. Remove blur.

SoTC Nop bloom. Can be removed.

FFX Games Unknown. Post processing?

Okami Unknown. Possible channel effect.

Red Dead Revolver Blur

Extra stuff

Display Offset Hacks Undo the hack mentioned here https://github.com/PCSX2/pcsx2/pull/1433. Will need a custom version of GSdx without the hack. I'll put a PR up at a later date. Patch the games listed in the original PR and any games that pop up.

SMT Nocturne Recently removed aggressive hack.

SMT DDS Recently removed aggressive hack

SMT DDS2 Recently removed aggressive hack

MrCK1 commented 4 years ago

Here is an example of on-screen garbage in Tomb Raider Underworld (and associated games in the series) - it's an old image, so this should still be checked by someone who owns the game or has a GSDump.

MrCK1 commented 4 years ago

Around last year me and @lightningterror also tested Urban Reign a while back but had no luck triggering the CRC hack.

MrCK1 commented 4 years ago

The CRC hack is no longer required for Timesplitters 2 and a patch isn't necessary. It was used for removing a 4-player overlay in HW renderers. The CRC meta issue mentions that OGL has been fixed (as of May 2019) but both GL and DX are fine on current master branch.

On master (July 2020), the hack behavior removes 2 things:

Original bug (image)

Sniper scope: (Automatic CRC, master): pcsx2_2020_07_25_22_07_38_634

(None, master): pcsx2_2020_07_25_22_07_46_497

Environment: Automatic CRC, master) NAPS2_2020_07_25_22_24_50_298

(None, master): NAPS2_2020_07_25_22_24_59_201

lightningterror commented 4 years ago

Spartan, Crash are channel effect, Urban Reign skips bad draw (black rain, black stage) #3375 Tekken 5 is also half screen issue, one part of the hack. SOTC can be removed, HPO works perfect. VP2, Star Ocean you will need to add SW blending support to dx. Kunoichi/Nightshade some are needed which are broken depth effects.

ghost commented 4 years ago

I remember i made some patches for Steambot Chronicles, and Raw Danger! For Steambot i posted it on forum here, but some tests are probably needed. For Raw Danger! i didn't posted it yet (i will today), those are 100% tested on other platforms.

Added Raw Danger! patches on forum: link

tadanokojin commented 4 years ago

Thank you all. I updated with your information.

I'll note that for CS effects the patch is the superior solution as it can remove expensive code on the EE side of things. It's even good as a speedhack even after we fix it.

For the other stuff, I'd like to patch it if we can (of course we'll try to fix it too). Stuff that is really broken we can discuss gamedb solution for (I'd like to avoid it as much as possible) but I still want to track everything even if it gets patched.

Added note about Stolen.

lightningterror commented 4 years ago

For the other stuff, I'd like to patch it if we can (of course we'll try to fix it too). Stuff that is really broken we can discuss gamedb solution for (I'd like to avoid it as much as possible) but I still want to track everything even if it gets patched.

I'm against removing such crc hacks and replacing them with gamedb patches. You'll be affecting the sw renderer too. We fix the issues properly then we can remove the hacks like we always do.

tadanokojin commented 4 years ago

Appeal to tradition arguments are bad arguments. Maybe the gamedb or the patch system needs improvements.

Let's get SotC and Timesplitters removed since those two are low hanging fruit.

tadanokojin commented 4 years ago

In GSState there is a hack for handling invalid PSM in International Star Soccer https://github.com/PCSX2/pcsx2/blob/91326e1d93b9e1d06fe6e91346d2138cd3eaa92e/plugins/GSdx/GSState.cpp#L895-L902

This is undoubtedly a core issue as 0x3 PSM while paletted wouldn't work in place of PSMT8 as it features different swizzling. Here's an example of a PSMT8 texture: 005556

Here is that same texture with the PSM set to 0x3: 005555

Additionally, DobieStation manages to display the textures in question correctly for this game. This game has symbols and should be debugged to find the issue.

i30817 commented 4 years ago

There is a patch to remove blur for digital devil saga 2 in the thread (doesn't work on cutscenes for some reason, maybe different camera object).

tadanokojin commented 4 years ago

@i30817 thank you, updated

ghost commented 3 years ago

https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=614740#pid614740 This should work as Tales of Legendia CRC hack replacement according to patch description.

felixthecat1970 commented 3 years ago

Evangelion - Jo (Japan) SLPS_259.32 CRC = 0xCBB87BF9 i think CRC hack now can be removed with this pnach https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=619142#pid619142

felixthecat1970 commented 3 years ago

Fighting Beauty Wulong (Kakutou Bijin Wulong (Japan) SLPS_256.57;1) Game CRC = 0x4A4B623A) another game i think crc hack can be removed https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=619179#pid619179

felixthecat1970 commented 3 years ago

Ikki Tousen - Shining Dragon (Japan) SLPS_257.98;1) Game CRC = 0x9E98B8AE another game can be retired from crc hack and be reemplaced by this pnach https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=619441#pid619441

tadanokojin commented 3 years ago

@felixthecat1970 @kozarovv thanks for your hard work. I'll get these hacks purged when the merge is done in the meantime feel free to keep looking into more of them. Thanks a million!

felixthecat1970 commented 3 years ago

Onimusha: Dawn of Dreams (Usa/Japan) editions not require CRC Hack Level, upscaling missaligment can be addressed with half-pixel offset>"Special texture" (still missaligmen upperscreen but no so notable), about post effect metioned "fog" or better "dirt" in this game is intense because first levels are designed to look like "western town" disabling post effects code look too pale but i make some codes for partial disable BLUR -DOF making image more clearer, IMAGE with "tweaked" post-effects oni4-twef

IMAGE with no post-effects oni4-noef

for codes thread https://forums.pcsx2.net/Thread-No-interlacing-codes?pid=619401#pid619401 keeping in mind effect like "blur" has a impact in GS disabling reduce game load from 98% to 64% also for DOF in some scenarios (ryzen 3400g with integrated vega 11 gpu HW mode 3x default options) apart the game still has the bug about IPU corrupted images (reduced corruption by kozarov lastest workaround in forums)

ghost commented 3 years ago

Hack replacement for one of Tenchu games: https://forums.pcsx2.net/Thread-Post-your-PCSX2-cheats-patches-here?pid=619981#pid619981 . Probably other one use the same engine, so should be easy to port when needed.

RedDevilus commented 2 years ago

https://github.com/PCSX2/pcsx2/issues/4309#issuecomment-976040356

FFX CRC Hack 'fixes' the transition effect from world map to random encounter battle.

marcoluc97 commented 2 years ago

See https://github.com/PCSX2/pcsx2/pull/5593 for the first PR. We still need to track all of these or something is changed? There are many games updated in these weeks about GS involved.

dio-gh commented 2 years ago

Crash: Wrath of the Cortex Channel effect

Partially fixed / worked around by #5990, through the utilization of Frame Buffer Conversion and Preload Frame Data. To the extent I can tell, these features delegate work back to the CPU, so in a sense they could be considered as not a real fix.

Still an issue on DX backends.

The given hack also helps upscaling. Without it, the fog on the first level is striped and generally broken on all backends still.