PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator

https://pcsx2.net

GNU General Public License v3.0

11.8k stars 1.63k forks source link

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug Audio CDs won't play any music anymore in the BIOS.

Note: Now when playing a audio CD, the PCSX2 console spams: NCMD Unknown 7

To Reproduce Load the BIOS with a standard audio CD in the virtual tray.

Expected behavior The various tracks on the disc should play fine.

Emulation Settings Everything default.

Regression pull request: https://github.com/PCSX2/pcsx2/pull/1583

System Info PCSX2 Revision: pcsx2-v1.7.0-dev-pr[4171] OS: Windows 10 CPU: I9 9900k GPU: RTX 3070

turtleli commented 3 years ago

That regression pull request isn't correct.

Note: Now when playing a audio CD, the PCSX2 console spams: NCMD Unknown 7

3899 is responsible for that, re-adding the large section of deleted code makes it play though the playback is pretty bugged - it repeats itself a lot and the time increments slowly. So there is another regression somewhere.

turtleli commented 3 years ago

The faulty playback was caused by #3877.

maxdlpee commented 3 years ago

I don't think this is really of much priority tho, given that you can use your PC to play those Audio CDs, and not bother with PCSX2 at all.

refractionpcsx2 commented 3 years ago

The faulty playback was caused by #3877.

wait, what? how?

The PR that completely removed the CD Audio read calls seems a lot more freaking likely to me than the change of the read speeds.

turtleli commented 3 years ago

I think there's a misunderstanding. #3899 made audio unplayable, whereas #3877 made audio sound buggy because the CD read speed is too slow.

refractionpcsx2 commented 3 years ago

I see, I'm not sure how it's too slow, unless it's not CAV when it's doing CD Audio reads, which makes sense I suppose.

turtleli commented 3 years ago

Here's some amusing playback with the deleted code put back in. "10s"

10s with CD speed change reverted (it's not perfect, but yeah)

seta-san commented 3 years ago

If this is a cd read speed issue couldn't this bug help dial into the ps2s exact read speed and maybe help fix other games with cdvd issues?

refractionpcsx2 commented 3 years ago

I suspect audio cd's velocity changes so the speed matches wherever on the cd you are, it's only PS2 games where it uses CAV.

ghost commented 2 years ago

Thanks to the various CDVD timing changes, this is not an issue anymore, the only remaining gremlin is this log:

refractionpcsx2 commented 2 years ago

Apparently 0x2009 is the mode for the "where" registers 0x200c-0x200e (sec/min/hrs?)

0 = audio cd 1 = cd/dvd or something 2 = dvd

The reason it doesn't matter that we don't emulate it currently is because we're basically in permanent audio cd mode.

StillPlay2 commented 2 weeks ago

The problem stems from #7742