PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
Other
10.61k stars 1.54k forks source link

[BUG]: Silent Hill 2 Black Ribbon demo: Improper FMV brightness/ broken preload frame data behaviour. #4939

Open ghost opened 2 years ago

ghost commented 2 years ago

Describe the Bug

In the video demo "Silent Hill 2 Black Ribbon", the FMVs are not displayed properly. They are too dark in hardware. Software does display them just fine.

Note: Preload frame data is the only hack to do something about this, and it makes the FMV more broken that it originally is.

Reproduction Steps

Load the demo disc, and see the FMV.

Expected Behavior

The FMV should be displayed like in software mode.

PCSX2 Revision

v1.7.0-dev-1957-gb63f6e807c

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

I9 9900k

GPU

RTX 3070

GS Settings

Native resolution, preload frame data.

Emulation Settings

No response

GS Window Screenshots

The bug in action:

Software rendering:

1

Hardware rendering:

2

Hardware + preload frame data:

3

Logs & Dumps

GSdump: SH2 Video demo brightness problem.zip

prafullpcsx2 commented 2 years ago

I think you uploaded the wrong gsdump. Can you check and upload right one?

ghost commented 2 years ago

Sorry for the delay, here is one more dump: SH2 video demo hardware problems.zip

prafullpcsx2 commented 2 years ago

Can you upload a block dump too?

refractionpcsx2 commented 2 years ago

it's probably the scale point thing we do internally because it looked terrible on FMV's.. I'm pretty sure FFX-2 is the same where it looks darker in HW mode than SW, I'm not sure why though, not sure what the preload frame thing changes.

ghost commented 2 years ago

Here is the blockdump: https://drive.google.com/file/d/18mInnnx7MFXJAA3RvhknLkDKkJTTVFlR/view?usp=sharing

Mrlinkwii commented 11 months ago

how is this on latest nightly?

StillPlay2 commented 11 months ago

Broken & glitchy on latest 1.7.4857 Silent Hill 2 (Black Ribbon)  Video Trial  Vulkan 2 Silent Hill 2 (Black Ribbon)  Video Trial  Vulkan 3 Silent Hill 2 (Black Ribbon)  Video Trial  Vulkan 4 Silent Hill 2 (Black Ribbon)  Video Trial  Vulkan Silent Hill 2 (Black Ribbon) [Video Trial]_SLPM-61011_20230801155626.zip

StillPlay2 commented 11 months ago

Software Mode: Silent Hill 2 (Black Ribbon)  Video Trial _SLPM-61011_20230801155726

StillPlay2 commented 11 months ago

Notice the screenshots in my post; when you scroll up & down, they invert colours.

refractionpcsx2 commented 11 months ago

I think that's just a visual effect because it's only rendering every other line.

The garbage is MAD not handling that missing every other frame very well at all.

StillPlay2 commented 11 months ago

It gets more & more glitchier as you go along.

refractionpcsx2 commented 11 months ago

probably, yes, but the issue hasn't changed :P

StillPlay2 commented 3 months ago

The glitchyness has been fixed but the darkness remains on 1.7.5592. This also requires blending accuracy to be set to Full. Silent Hill 2 (Black Ribbon)  Video Trial _SLPM-61011_20240304160323 Silent Hill 2 (Black Ribbon)  Video Trial _SLPM-61011_20240304160318 Silent Hill 2 (Black Ribbon)  Video Trial _SLPM-61011_20240304160311

Mrlinkwii commented 3 months ago

@StillPlay2 can i get an updated gs dump if thats ok :)

StillPlay2 commented 3 months ago

GSDump from 1.7.5616: Silent Hill 2 (Black Ribbon) [Video Trial]_SLPM-61011_20240315143232.gs.zip