PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.49k stars 1.6k forks source link

[BUG]: Ratchet and Clank Going Comando: Mipmapping glitches with the software render #5008

Open ghost opened 2 years ago

ghost commented 2 years ago

Describe the Bug

The game "Ratchet and Clank Going Comando" suffer of some graphical glitches when using the software render and mipmapping together.

Reproduction Steps

Load the GSdump and see the problem.

Expected Behavior

The game should not have those tiny glitches and work like it "does" (in quotes because hardware is far from perfect) with the hardware render.

PCSX2 Revision

Build from this PR: https://github.com/PCSX2/pcsx2/pull/5006

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

I9 9900k

GPU

RTX 3070

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

The bug in action:

Software: 1

Hardware: 2

Logs & Dumps

GSdump: gs_20211111131049.zip

refractionpcsx2 commented 2 years ago

This is to do with how the LOD (and the K component of the calculate) is rounded in the "round off" mode, it's not quite right. I can make it look correct, but pretty sure I'm just fudging the numbers.

HelicopterP commented 2 years ago

The same issue also applies to original Ratchet and Clank. You can see it on crates in the first level.

TheTechnician27 commented 8 months ago

There's a little pebble in Metropolis (RaC 3) that I just saw do this too in SW mode.

TheTechnician27 commented 7 months ago

Alright, so I've seen this crop up a few places:

Ratchet & Clank 2 - Going Commando_SCUS-97268_20240118223416.zip In GC, it seems to show up on the bolt crates.

Ratchet & Clank 2 - Going Commando_SCUS-97268_20240210153942.zip I was able to reproduce the issue shown in the screenshot, but because its shape changes from frame to frame and it disappears quickly, I've created a multiframe for it.

Ratchet & Clank - Up Your Arsenal_SCUS-97353_20240210154849.zip This can similarly be found in RaC 3 (this was taken in Metropolis; this is also present on the pebbles there, but they're so fickle that it's basically impossible to capture in a GS dump.)

Whether this is present in R&C1 and Deadlocked would require further testing to determine. I pretty much don't use SW mode, but I can test Deadlocked for a bit.

TheTechnician27 commented 7 months ago

Ratchet - Deadlocked_SCUS-97465_20240210160525.zip This was shockingly fast compared to how long I thought it would take to find this: it's present in Deadlocked as well. Now just to see if it's in R&C1 (it's unlikely to be present in Size Matters or Secret Agent Clank).

TheTechnician27 commented 7 months ago

Ratchet & Clank_SCUS-97199_20240210161042.zip Rounding out the quadrilogy: it's present in R&C1 as well.

TheTechnician27 commented 5 months ago

I could be mistaken here, but I think I've found a big instance of this in Ratchet and Clank 3 in the disco ball on Obani Draco. Included are two screenshots as well as two GS dumps, as for some reason, the garbage circle tends to contract or expand depending on how far you are from it.

Ratchet & Clank - Up Your Arsenal_SCUS-97353_20240402112341.zip