PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
Other
10.62k stars 1.54k forks source link

[BUG]: Die Hard: Vendetta- Arm twitching on both renderers, texture/mipmapping issues on HW renderer #5127

Open HeroponRikiBestest opened 2 years ago

HeroponRikiBestest commented 2 years ago

Describe the Bug

Both renderer issues-

HW Renderer issues-

Additional notes: There seem to be some artifacts visible on the HW renderer just after the load screen ends on multiplayer, possible on singleplayer as well. I am unable to provide GSdumps, as at the moment I cannot produce a single GSdump from ctrl + shift + f8, and the timing would be too precise for me to capture it with just shift + f8. If I can resolve that issue, I will update this post with the aforementioned GSdump.

These issues were observed on both the European and German versions of the game. The only difference noticed between these versions is that swapping the renderer during a load screen makes the background disappear on the German version, while swapping renderers does nothing on the European version, and the background will only disappear on a load screen if you load a save state during it. Obviously, neither of these things are issues.

To anyone testing the game in the future: yes, the gate on the first mission is supposed to look like that, even on a real PS2. It only looks correct on the xbox version, which was probably the main target for this port.

Reproduction Steps

All issues will be normally experienced by starting a new game and playing from there. In order to see the twitching on your arm, press circle to outstretch your gun during gameplay.

Expected Behavior

Expected behavior was laid out in the bug descriptions.

PCSX2 Revision

PCSX2 1.7.0-0 - compiled on Dec 9 2021 (daily ppa doesnt show git number)

Operating System

Linux (64bit) - Specify Distro Below

If Linux - Specify Distro

Linux Mint 20.2

CPU

AMD Ryzen 7 PRO 4750U with Radeon Graphics

GPU

Integrated graphics, see above

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

No response

prafullpcsx2 commented 2 years ago

Can you make a gsdump using dev 1961 or earlier so we can test old gs versions and rule out that it's a regression (for twitching bug)?

HeroponRikiBestest commented 2 years ago

Tested arbitrarily using https://github.com/PCSX2/pcsx2/actions/runs/1396343026. All issues appear to be present. gs_20211212092037.gs.zip

prafullpcsx2 commented 2 years ago

https://buildbot.orphis.net/pcsx2/index.php?m=dl&rev=v1.7.0-dev-1961-g4273b6ce37&platform=windows-x86

HeroponRikiBestest commented 2 years ago

I use Linux; furthermore, that PR I linked was made a few days before dev 1961, so it should be valid here.

prafullpcsx2 commented 2 years ago

It still gives savestate too old to be read message when trying to open the gsdump. Anyway I will check the game myself and see what can be done.

HeroponRikiBestest commented 2 years ago

@prafullpcsx2 I was able to get 1961, sorry about that. Here's a gsdump; all issues still seem to be visible gs_20211212105738.gs.zip

prafullpcsx2 commented 2 years ago

@HeroponRikiBestest Thanks. Looks like twitching has always been there on pcsx2 so it's not a regression.

HeroponRikiBestest commented 2 years ago

Yeah; again, sorry about getting the wrong dev build, I know what to do in the future now at least. Any idea about the HW mipmapping issues?

Dreadmoth commented 2 years ago

Does either of the Trilinear Filtering modes improve the appearance of the textures? (Config → Graphics Settings → Hacks → Trilinear Filtering)

HeroponRikiBestest commented 2 years ago

It helps, but it has a similar effect to mipmapping basic/full, where it only partially fixes them.

HeroponRikiBestest commented 2 years ago

I don't know if I just didn't notice it before or it was introduced recently, but now SW mode gets some red and/or blue garbage in the bottom left. It's a little hard to notice in screenshots, but its pretty noticeable in motion. gs_20211231030742 gs_20211231030742.gs.zip

lightningterror commented 1 year ago

Mipmapping issues should be resolved now.

Mrlinkwii commented 11 months ago

which issues are left here ? since the Mipmapping issues were sloved

refractionpcsx2 commented 10 months ago

We did some testing and it seems to be affected by rounding on VU0 and FPU