search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.71k stars 1.62k forks source link

[BUG]: Dark Cloud 2 (SCUS-97213): HUD visual glitch (texture sampling?) #5261

Open trostboot opened 2 years ago

trostboot commented 2 years ago

Describe the Bug

There is some additional garbage on the lower right corner below the health bar portion of the HUD. Possibly a texture sampling issue, possibly related to https://github.com/PCSX2/pcsx2/issues/4440, although unlike that issue this one is present across all renderers (incl. the wip vulkan branch).

If resolution is set to a non-native multiplier on a HW renderer, and the Wild Arms hack is enabled, the issue is fixed. The issue stays fixed even if resolution is set back to native, as long as the HW hacks toggle is still enabled, even though the Wild Arms hack is greyed due to native resolution.

Verified to not be an issue on real hardware.

Reproduction Steps

Load game, enter any dungeon area, move eye focus to upper left of screen.

Expected Behavior

Clean HUD with sweet sweet transparency.

PCSX2 Revision

1.7.2191

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

Ryzen R9 3900X

GPU

GTX 1080

GS Settings

Defaults, native resolution, SW/HW, no hacks. Workaround possible with Wild Arms hack.

Emulation Settings

defaults, no speedhacks

GS Window Screenshots

darkcloud2HUDglitch

Logs & Dumps

GSDump Memory card Savestate Simply enter the selected dungeon area from the saves.

coornio commented 2 years ago

Can confirm the graphical upscale bug in question on my side as well. Also, nice finding that hack discrepancy.

I'm not 100% sure if these extra few pixels were present at all a short while back, it's minor enough I might have glanced past it and ignored it. I'll jump back some versions to test and return.

EDIT: Been present since 1.6 at least so I've just been blind/ignoring it.

Mrlinkwii commented 1 year ago

how is this on latest nightly

coornio commented 1 year ago

It's still there, except now it occurs in software as well.

image image

refractionpcsx2 commented 1 year ago

It always occurred in software too. I know why it happens, but I need to do some tests on hardware to how it should be handled.

the game samples past the width of the texture (in page width, rather than texture size), which does weird stuff on real hardware and happens to not display the pixels from the next row in the texture, like here, but need to investigate further.

I have a bodge fix for this in #6553