PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.71k stars 1.62k forks source link

[BUG]: Devil may cry 3 special edition, ghosting, bloom issue, & "Scanline" issues #5300

Open LuismaSP89 opened 2 years ago

LuismaSP89 commented 2 years ago

Describe the Bug

Some ghosting and bloom issues in DMC3 special edition (PAL) it can be seen a lot in the last battle (Mission 20) The game has also some blue stripes issue, but this can be fixed by setting the half pixel offset to full (Texture) not only vertex. But it doesn't help with the bloom and the gosting.

GS Dumps attached.

Note: Tested with all backends, Vulkan, DX11 & Opengl, all the same.

Reproduction Steps

Start the last mission of the DMC3, the final battle.

Expected Behavior

No response

PCSX2 Revision

1.7.2212

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

i7 4790k

GPU

GTX 970

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

snaps.zip

MrCK1 commented 2 years ago

It sounds like this only occurs when upscaling, is that correct?

LuismaSP89 commented 2 years ago

Mmm... seems not, I tested now with ps2 native res and also the same issue.

Mrlinkwii commented 1 year ago

is this an issue on latest nightly ?

LuismaSP89 commented 1 year ago

Yes, the ghosting and the bloom is still present on the latest nightly

Mrlinkwii commented 1 year ago

can this be rechecked on latest nightly :)

LuismaSP89 commented 1 year ago

can this be rechecked on latest nightly :)

This improved a lot on the latest nightly but still present. Also there is a a new issue (tested nightly builds from some months ago and the same happens, so the issue is not very new) but this time the game has some kind of scanline issue. It looks like and old TV, there are lines on the entire screen.

Mrlinkwii commented 1 year ago

@LuismaSP89 can i have a gs dump?

LuismaSP89 commented 1 year ago

@LuismaSP89 can i have a gs dump?

Sure. Hold on.

LuismaSP89 commented 1 year ago

@LuismaSP89 can i have a gs dump?

Here you go Sir, 3 Gsdump with the scanline problems on it. Let me know if you want any further testing.

snaps.zip

LuismaSP89 commented 1 year ago

PS: As far as I tested, this is happening also in the other Devil may Cry games, specially on the first one.

Mrlinkwii commented 1 year ago

these look fine here

image image

image

did you happen to enable shaders/ change interlacing by accident ?

Jakey757 commented 1 year ago

You have the same interlacing artifacts in those pictures @Mrlinkwii. Adaptive de-interlacing just does that, its more or less noticeable in different situations.

LuismaSP89 commented 1 year ago

Yes. That's exactly @Jakey757 said. The artifacts are also present in your screenshots, you can see it doing zoom on the images. I already played with the interlacing options but no one seems perfect for this game, and if it's changed it also break other things.

MrCK1 commented 1 year ago

The dumps look fine to me with Blend, Bob or None modes. No scanlines whatsoever.

I'm not sure what "blue stripes" are being referred to unless someone can provide an example

mirodno commented 1 year ago

The only way to eliminate interleaving artefacts without choosing bob deinterlace is through forcing progressive rendering, which looks crappy on native resolution, but since you're upscaling anyway...

Insert this into 18C9343F.pnach in "/cheats" folder

[Progressive scan (224p)]
author=felixthecat1970
comment=Converts 512x448i into 512x224p
patch=0,EE,201EE060,extended,0000202D
patch=0,EE,201EE264,extended,0000182D
patch=0,EE,00513830,extended,24420004
patch=0,EE,2051368C,extended,AE210048
patch=0,EE,20102C84,extended,3C0700E0

Taken from https://github.com/felixthecat1970/gamepatches/blob/main/Playstation_2/Devil%20may%20cry%203%20(Series)/cheats/18C9343F.pnach I only copied lines associated with progressive scan, the others are irrelevant in this case (they remove ghosting filter in a few locations)

And bloom issues — it's in-game problem. Special effects seems to be hard-coded to specific locations in 512x448i frames, and even Vertex HPO doesn't fix all of them, like some light sources are still slightly off their intended location (most noticeable on first 2 lamps in the mission 3 bar). It's not taking in count the fact that effects are butchering the further the higher upscale goes. I'm saying all of this because progressive scan makes this problem even more pronounced, so I suggest trying bob-bottom-field instead with high upscale value like 4x. If it's too much for hardware, then progressive scan and 2x. Still looks crappy, but no judder and stuff.

I gave up long time ago for workarounds (all of them either crappy but "kinda working" or working really good until you reach some of specific locations...), and now playin' like back in 00s with native resolution. It's a bad in "calm" scenes with no enemies, but when action hits, it's somehow doable... or even unnoticeable, considering amount of things i need to worry about :^) Sad, that PAL resolution is broken (or it's a broken deinterlace?), it could make a native res gaming less painful...

Also, it's funny how first DMC got right an opposite of DMC3's problems — special effects are wonderfully upscaled, but the HUD...

P.S. Also, i just noticed that my article placing sucks mass, sorry for that, not my native language :^(