PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.74k stars 1.62k forks source link

[BUG]: Time Crisis 2: Visual bugs #5966

Closed waspennator closed 1 year ago

waspennator commented 2 years ago

Describe the Bug

For some reason, this game seems to have slight visual glitches across all of the backends. The Vulkan and OpenGL renderers have a noticeable white square that seems to stick around in the top left corner of the screen. DX11 and DX12 renderers have that, as well as the screen being a brighter white then usual. Software Renderer doesn't have either of the issues, but the demo play text looks garbled and warped.

Reproduction Steps

Skip the intro and let the game go to demo play and it should be noticeable right away.

Use Vulkan and OpenGL for the white square at the top left.

Use DX11 and DX12 for the white square and a strangely brighter screen.

Use Software to see the demo play text garbled.

Expected Behavior

There should be no white square at the top left of the screen during gameplay, weird white bright filter, or garbled demo play text.

PCSX2 Revision

v1.7.2658

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

Ryzen 5 5600H

GPU

GTX 1650

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

Vulkan and OpenGL Renderers: Time Crisis Vulkan screen bug

DX11 and DX12 Renderers: Time Crisis 2 DX12 screen bug

Software Renderer: Time Crisis 2 Software screen bug

Logs & Dumps

Time Crisis 2 - Visual Bugs DX12.zip Time Crisis 2 - Visual Bugs Software.zip Time Crisis 2 - Visual Bugs Vulkan.zip

Tested with Vulkan, DX12, and Software renderers.

lightningterror commented 2 years ago

For dx11/12 they will need High blending for the brighter screen.

F0xH0L3 commented 2 years ago

This issue started at v1.7.2301, earlier 1.7 versions have had different graphical glitches, but not this one. V1.6 didn't have any graphical glitches. Anyways, to get around this issue, turn on "Disable Depth Emulation" hack. Just note that this isn't the only graphical glitch, there's another one that seems to happen very randomly at stage 1 just after you go out the window. Basically it gives the impression of something that looks like an image retention, for the lack of a better description.

refractionpcsx2 commented 2 years ago

2301? then maybe @tellowkrinkle can have a look, or @iMineLink since they kind of worked on that code (the resizing stuff) together.

F0xH0L3 commented 2 years ago

If i can be of any help, feel free. Though i'm not a coder, but i am a very diligent tester.

refractionpcsx2 commented 2 years ago

The GS dumps in the original post should be enough for now, thanks.

dudesh34 commented 2 years ago

Time crisis 3 has the same white square on the left upper screen on vulkan and opengl now. didnt have thiseon old versions.

F0xH0L3 commented 2 years ago

Time crisis 3 has the same white square on the left upper screen on vulkan and opengl now. didnt have thiseon old versions.

Same fix applies, turn on "Disable Depth Emulation" hack.

dudesh34 commented 2 years ago

i cant find the "Disable Depth Emulation"...where is it?

dudesh34 commented 2 years ago

found it...now the only problem are the huge stuttering and slowdowns...which i dont have in older versions from 2 years ago.

Comfarol commented 1 year ago

This issue still persists. At first these settings help the issue at the beginning of the game, "Disable Depth Emulation" and "High Blending" enabled. But the problems show up again later in the game. Only now with USB merge have I been able to progress and test it.

image

PCSX2 Nightly - v1.7.3732 SCES-50300

RedDevilus commented 1 year ago

Can you make a gs-dump on the moment(s) of when the issue happens?

How To Create A GS Dump What is a GS dump? A GS dump is a dump of PS2 graphics data. The dump allows helpers, testers and developers to figure out how to fix graphics bugs.

Where do I make the dump? Get to a point in your game where the graphics bug is clearly visible. The issue must appear on your screen in order for it to be captured in the dump.

How do I make the dump? Stable 1.6.0 and Nightly 1.7 wxWidgets: Use the key combination Shift + F8

Nightly 1.7 Qt: Tools > Save Single Frame GS Dump

Where does the GS dump save to? GS dumps are saved to the /snaps folder.

Your graphics settings DO NOT affect the dump, and you will not need to change renderers, hardware fixes or any other settings.

More information on the PCSX2 forums: https://forums.pcsx2.net/Thread-How-to-create-a-proper-GS-dump

Comfarol commented 1 year ago

I have some more info as i test. It seems to be remnants from or related to the FMV. Skipping the FMV sometimes results in no artifacts, but letting it play almost always leaves the issue.

I'll get a dump in a moment

image

Comfarol commented 1 year ago

Do you want the gs.zst file? It says it doesnt support that file type

RedDevilus commented 1 year ago

Do you want the gs.zst file? It says it doesnt support that file type

Just zip it (or might to extract and put that in a zip format)

It's just github limiting certain extensions.

Comfarol commented 1 year ago

Time Crisis 2_SCES-50300_20221219101239.gs.zst.zip

Comfarol commented 1 year ago

Just note that this isn't the only graphical glitch, there's another one that seems to happen very randomly at stage 1 just after you go out the window. Basically it gives the impression of something that looks like an image retention, for the lack of a better description.

Should this issue have its own topic, as it is more related to foxholes description and not OP

dudesh34 commented 1 year ago

yes, time crisis 2 has regressed for sure in the 1.7 builds in terms of gfx...wonder why.

RedDevilus commented 1 year ago

Just note that this isn't the only graphical glitch, there's another one that seems to happen very randomly at stage 1 just after you go out the window. Basically it gives the impression of something that looks like an image retention, for the lack of a better description.

Should this issue have its own topic, as it is more related to foxholes description and not OP

Whatever fits the best to you.

It gets cleared by pressing F9 twice (changing to software and back):

image

Can't do much with a texture cache issue which is unfortunate. Needs more research.

Comfarol commented 1 year ago

It doesn't happen in 1.6 though, so something has caused it?

RedDevilus commented 1 year ago

Changes happen all the time and not always for the better, called a regression.

Comfarol commented 1 year ago

Sometimes it doesn't show up though, which is odd. Watching or skipping FMV.

lightningterror commented 1 year ago

This issue still persists. At first these settings help the issue at the beginning of the game, "Disable Depth Emulation" and "High Blending" enabled. But the problems show up again later in the game. Only now with USB merge have I been able to progress and test it.

image

PCSX2 Nightly - v1.7.3732 SCES-50300

Can you create that exact dump on build v1.7.2300 https://buildbot.orphis.net/pcsx2/index.php?m=dl&rev=v1.7.2300&platform=windows-x86

Comfarol commented 1 year ago

gs_20221219121444.gs.xz.zip gs_20221219121444

Is this right? I haven't noticed any of the above so far with v1.7.2300, ive let cinematics end/skipped and started a few times.

lightningterror commented 1 year ago

With a bit of investigation the commit that caused the regression is https://github.com/PCSX2/pcsx2/commit/eca5eced63d216941b60ea907697143dd2c9c4e9

waspennator commented 1 year ago

Testing out the other 2 Time Crisis games, like dudesh said. Opengl and Vulkan have the white square on the top left and dx11 and 12 have that whitish screen filter for 3 which can be fixed with disable depth buffer and high blending. (though no noticeable issues from first glance on software) Crisis Zone doesn't seem to have any noticeable issues at all visually or audio cutscene wise at first glance.

Comfarol commented 1 year ago

Played so much of the US copy of TC2 today and been unable to produce the error. If anyone else could test the two versions to confirm that it's just the PAL copy? (with disable depth buffer and high blending enabled)

RedDevilus commented 1 year ago

Played so much of the US copy of TC2 today and been unable to produce the error. If anyone else could test the two versions to confirm that it's just the PAL copy? (with disable depth buffer and high blending enabled)

At that point shouldn't the Software Renderer be a better test to not be distracted with texture cache or other issues? Unless it's just for the visual errors as the PR title suggests.

Comfarol commented 1 year ago

Its just the visual errors, software mode runs it perfectly from what i've observed.

Comfarol commented 1 year ago

I noticed this issue again on newer version 1.7.4446 last version i tried doesn't seem to have it 1.7.4379

Time Crisis II_SLUS-20219_20230501132032

Time Crisis II_SLUS-20219_20230501132032.gs.zst.zip