search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.86k stars 1.63k forks source link

[BUG]: Extreme flickering in Neo Contra (SLUS-20961) opening cinematic #6140

Closed Tyestor closed 2 years ago

Tyestor commented 2 years ago

Describe the Bug

Extreme flickering in Neo Contra opening cinematic. No issue in software renderer, issue is present in OpenGL and D3D11. Cannot test D3D12 or Vulkan because my GPU is too old.

This flickering is bad enough that it will cause seizures in photosensitive epileptics (I am one of them, have to cover my eyes).

Reproduction Steps

Fast/full boot game with qt ui, get past company logos, watch opening cutscene

Expected Behavior

No flickering like in this youtube video: https://www.youtube.com/watch?v=azVh3H_EP6E

PCSX2 Revision

PCSX2 Nightly - v1.7.2775 (Qt) SSE4

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

i5 2500k

GPU

Radeon HD6950

GS Settings

default

Emulation Settings

default

GS Window Screenshots

epilepsy warning:

https://gfycat.com/threadbareunfoldedcirriped

Logs & Dumps

i tried but i can't seem to get a gs dump in qt version.

stenzek commented 2 years ago

From a quick check the texcoords are out of range in the merge on the "borked" frames, but the input texture/source is fine.

Software is fine.

Tyestor commented 2 years ago

just checked a slightly older build "pcsx2-v1.7.2460-windows-64bit-SSE4" - issue still persists here (D3D11/OGL). the issue also happens in another game "monster attack" (SLES-51856) where on startup a company logo flickers a lot. software mode is fine here.

i also checked the 1.6.0 stable build - the issue is not present here for neo contra. both D3D11 and OGL work. however, monster attack is broken as far back as this stable build. it's possible its a different issue, although its a similar effect.

stenzek commented 2 years ago

basically, it's two images, one at 0000, one at 1180 or whatever with conservative fb on, we cut the first one off at 512 because it's 448 high, we say "well, that's a partial hit", and don't create a target at 1180 even though it's only 64 pixels of the 448 it needs

tldr; disable conservative fb in game properties, or use software for fmvs, but we're looking into another possible solution which won't need it

Tyestor commented 2 years ago

Disabling conservative buffer allocation fixed both neo contra and monster attack. Thank you.

Tyestor commented 2 years ago

Closing this. https://github.com/PCSX2/pcsx2/pull/6142 Fixes this issue.