PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.58k stars 1.6k forks source link

[BUG]: Final Fantasy X, Bugged Aeon Graphical Effects #7424

Open vcx33 opened 1 year ago

vcx33 commented 1 year ago

Describe the Bug

Yojimbo His katana is fully or partially invisible, happens at random, sometimes there is no glitch at all, happens on both hardware and software mode

Software mode: aa

Hardware mode: aaa

Correct display: ccc

Anima The purple special effect clips with the model, this only happens in hardware mode

ee

Correct display in Software mode:

dd

Magus Sisters

The special effect doesn't consume the entire floor in hardware mode, a glitched white square appears on the top left corner of the screen on both hw and software mode

Hardware mode: Final Fantasy X International_SLPS-25088_20221120023912 a

Software mode: b

GS Dumps:

Anima: Final Fantasy X International_SLPS-25088_20221120022824.gs.zip

Magus Sisters: Final Fantasy X International_SLPS-25088_20221120023912.gs.zip

Reproduction Steps

Summon an aeon fill up the its overdrive and use it

Expected Behavior

No response

PCSX2 Revision

v1.7.3589

Operating System

Linux (64bit) - Specify Distro Below

If Linux - Specify Distro

No response

CPU

i7-4700

GPU

GTX 2060

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

No response

refractionpcsx2 commented 1 year ago

The Anima with the cut off texture needs Tex in RT.

the circle thingy also needs Tex in RT but also Full blending (on VK/OGL)

Not sure about the other thing.

Tex in RT probably needs adding to the DB

LeCharlatan commented 1 year ago

Hi @vcx33, Is the bug still happening for you ? If so, can you share your memory card here ? I'd like to see if the bug is happening here too, thanks

refractionpcsx2 commented 1 year ago

I added a bunch of stuff to the DB for this, so it should be mostly fixed, but you will need Full Blending as I mentioned in my previous post

vcx33 commented 1 year ago

the anima overdrive bug is fixed, i also found a new issue and it doesn't seem to be a regression. Final Fantasy X International_SLPS-25088_20230107164629 Final Fantasy X International_SLPS-25088_20230107164629.gs.zip this is what happens during the summoning animation, but only in certain areas.

the magus' sisters circle is mostly fixed it still has that box on the top left corner when using hw mode and when blending accuracy is set to full on vulkan Final Fantasy X International_SLPS-25088_20230107163908 sw mode Final Fantasy X International_SLPS-25088_20230107164040 hw mode Final Fantasy X International_SLPS-25088_20230107163908.gs.zip

the issue with yojimbos katana seems to be random hard to confirm if its fixed, didnt happen again last i checked.

he has another issue, though, his cape flickers, this is a regression, this did not happen on the build i tested before (1.7.3589).

https://user-images.githubusercontent.com/118646244/211162016-dde8540f-3202-4f33-87ea-6bad2c23d21d.mp4 real hardware

https://user-images.githubusercontent.com/118646244/211162040-49ddb32c-cec4-4db1-a552-2b03c9fc500e.mp4 pcsx2 Final Fantasy X International_SLPS-25088_20230107165209.gs.zip

tested on 1.7.3871

refractionpcsx2 commented 1 year ago

Can you retest this? thanks

vcx33 commented 1 year ago

all of the issues present on 1.7.3871 build are still present on 1.7.4126

the issue with anima seens to occurs when fighting a water flan and dingo in besaid, although it could occur in other areas as well.

another regression i found is an issue with the anti-blur hack, previously this hack wasn't necessary but now without it the game is very blurry, but this causes another issue. The game mostly uses circle shadows, but in 2 specific instances it used proper real time shadows, when anima uses her overdrive and when fighting seymour omnis. This hack breaks the real time shadows and they appear interlaced. Also happens on software mode.

shadow1 shadow2

yojimbos invisible katana seems to happen in specific areas only, also only happens in hw mode yojimbo blade Final Fantasy X International_SLPS-25088_20230222182846.gs.zip

shiva has an issue with her summoning sequence that happens in both hw and software mode, to trigger it, go to the options menu and change aeon sequences to short, summon her in battle after, then, switch aeon sequences to normal and summon her again. shiva bugged 1 Final Fantasy X International_SLPS-25088_20230222184530.gs.zip shiva bugged 2 Final Fantasy X International_SLPS-25088_20230222184718.gs.zip

Correct Effect shiva normal shiva normal 2

vcx33 commented 1 year ago

As of 1.7.4344 the magus sister's box in the top left corner is fixed, but there is still a minor glitched line.

Yu Yevon also has a glitched box on the top left corner during his death animation, only in hardware mode though: Final Fantasy X International_SLPS-25088_20230407140642

GS Dump: Final Fantasy X International_SLPS-25088_20230407140642.gs.zip

vcx33 commented 1 year ago

As of at least version 1.7.4981 yojimbo's flickering cape has been fixed

https://github.com/PCSX2/pcsx2/assets/118646244/375e98f1-9225-4930-b5f0-8492c9980add

refractionpcsx2 commented 1 year ago

What about the other bugs? Keep in mind they probably need high blending (maybe Full, I forget)

It might be possible we can close this now.

vcx33 commented 1 year ago

Yojimbo's invisible katana issue still occurs

https://github.com/PCSX2/pcsx2/assets/118646244/cec2c6e3-14d6-4971-a261-24fe3e19ef98

Magus Sisters' issue has been mostly fixed but there is still a small artifact in the top left corner

https://github.com/PCSX2/pcsx2/assets/118646244/d39c25e0-80b8-4114-a350-f1b9ddde2054

Anima's issue still occurs

https://github.com/PCSX2/pcsx2/assets/118646244/685c8bb0-fd00-46b3-8a48-98485244274f

Yu Yevon's box in the top left corner is gone but now it displays this "Z" shaped seam artifact

https://github.com/PCSX2/pcsx2/assets/118646244/9ab6bedc-e38a-4a2b-8122-8154aa91ec77

Shiva's issue still occurs but it's random

Blending has been set to full and texture inside RT is disabled

refractionpcsx2 commented 1 year ago

Thats good, because Tex in RT shouldn't be on anymore :P

Can you provide savestates just before the problems show so we can test them ourselves?

vcx33 commented 1 year ago

Yojimbo SLPS-25088 (658597E2).01.p2s.zip Magus Sisters SLPS-25088 (658597E2).02.p2s.zip Anima SLPS-25088 (658597E2).03.p2s.zip Yu Yevon SLPS-25088 (658597E2).04.p2s.zip

to test these just press Circle and remove the .zip extension from the files

yojimbo's bug happens at random

for Final Fantasy X International [Undub] (Japan)

refractionpcsx2 commented 1 year ago

Thanks :)

refractionpcsx2 commented 1 year ago

well something is going really wrong with yojimbo, the savestate loads, you circle through the options, then it starts trying to access bad memory and crashes.

Edit: in fact every single one of these savestates TLB misses after trying to read the disc.

You're not using a modified ISO are you?

vcx33 commented 1 year ago

yes the game has an undub patch, but the issues are shared with the original non modified game. I'll post savestates from the original game from now on

Yojimbo SLPS-25088 (658597E2).01.p2s.zip

Magus Sisters SLPS-25088 (658597E2).02.p2s.zip

Anima SLPS-25088 (658597E2).03.p2s.zip

Yu Yevon SLPS-25088 (658597E2).04.p2s.zip

stenzek commented 1 year ago

Can you post a memory card save instead?

vcx33 commented 1 year ago

Two memory cards with saves from almost every point in the game, max stats and no encounter armor, for easier faster testing. memcards.zip