search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.58k stars 1.6k forks source link

[BUG]: Per-game "Start Fullscreen" setting doesn't work for everyone #7601

Open bslenul opened 1 year ago

bslenul commented 1 year ago

Describe the Bug

Hey!

As someone mentioned on Discord few days ago, the "Start Fullscreen" setting doesn't work on a per-game basis. So having it disabled globally but enabled per-game, the game will still start windowed. And vice-versa, having it enabled globally and disabled per-game, the game will still start fullscreen.

I checked the game .ini and it properly contains

[UI] StartFullscreen = true

Worth noting that some people on Discord were able to reproduce but it seems to work for others, so maybe it's conflicting with another setting somehow? Or OS specific (only tried on Windows 10 edit: happening on my Linux Mint VM as well)? I tried on a fresh PCSX2 install and it wasn't working for me with default settings.

Reproduction Steps

  1. Disable "Start Fullscreen" globally.
  2. Right click any game > Properties > Interface and enable "Start Fullscreen".
  3. Start the game.

Expected Behavior

No response

PCSX2 Revision

1.7.3726

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

Linux Mint 21.1 VM

bslenul commented 1 year ago

Finally reinstalled my Linux Mint VM (21.1 if it matters) and I can reproduce on it too.

stenzek commented 1 year ago

Working as expected tbh, the game settings layer isn't loaded when the VM first starts (the BIOS loads the game first), and the start full screen setting applies when the VM initializes.

So, we should either disable the setting in game settings, or pre-lookup the game settings ini when initializing the VM.... the latter seems a bit overkill just for one setting, but I guess it could potentially be used for per-game BIOS too.

bslenul commented 1 year ago

the game settings layer isn't loaded when the VM first starts (the BIOS loads the game first), and the start full screen setting applies when the VM initializes.

Ah I see, makes sense then. Although now I'm even more confused about one of the devs on Discord not being able to reproduce the issue back when it was mentioned :D Probably just a misunderstanding.

we should either disable the setting in game settings, or pre-lookup the game settings ini when initializing the VM....

I have no idea how much work that would require but yeah, might not be worth :/ Would there be any use case for per-game BIOS? 🤔

Thanks for the reply/explanation! 👍

stenzek commented 1 year ago

Would there be any use case for per-game BIOS? 🤔

Maybe not per-game, but per-region, yes - full booting only works if the disc matches the BIOS region, due to software checks.

bslenul commented 1 year ago

Ah OK, I thought PCSX2 was already switching BIOS automatically depending on the game region. I'm a Fast Boot user so not affected by this, but I know some people love that PS2 boot animation, so it could be nice for the purists :D