PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.62k stars 1.6k forks source link

[BUG]: USB - GunCon 2's calibration shots not always work as intended #7618

Open IlDucci opened 1 year ago

IlDucci commented 1 year ago

Describe the Bug

I have tested some PAL GunCon 2 games and found out that the Calibration Shot does not work sometimes as it should:

Reproduction Steps

Expected Behavior

PCSX2 Revision

v1.7.3735

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

i5-6600

GPU

RTX 2060

GS Settings

imagen imagen

Emulation Settings

imagen

GS Window Screenshots

No response

Logs & Dumps

No response

legend800 commented 1 year ago

I can confirm this - you cannot bypass the cali screen on Vampire Night because of this.

Time Crisis Crisis Zone also suffers from the same issue, except 1 out of every 20-30 shots I can get it to work on cali screen in that title, never on Vampire Night.

Fwiw, both of these games previously required nuvee plugin's setting "mouse calibration hack" and work perfectly with it on: 2022-12-18 14_32_17-Guncon - Port 1

Related, this can be closed now - it was locked and I can't do it: https://github.com/PCSX2/pcsx2/issues/3931

IlDucci commented 1 year ago

Time Crisis Crisis Zone

I was able to properly calibrate and take the proper measures from the PAL version with no problem.

Comfarol commented 1 year ago

try this for pal vampire night image

You need to find the correct values

IlDucci commented 1 year ago

try this for pal vampire night

Welp, those values actually unblock the calibration screen issue. The scale seems to be a teeny bit off when the cursor is close to the top and bottom, but at least the game works.

Comfarol commented 1 year ago

I can't test alot of the other games as I don't own them but try, see if those are better, looks better for me.

89.80 99.90 421.00 138.00 640px 256px

legend800 commented 1 year ago

Those work fine for Vampire Night, along with the below set posted in the other thread: 90.25, 102.75, 422.50, 137.00, 638px, 228px

Neither seem perfect as I need to shoot a few times in the target area on cali screen to get it to register. But once calibrated and in-game, seems perfect. Nice work!

Seems like the default/auto values are fine for NTSC but not many PAL games.

dante3732 commented 1 year ago

This works well for vampire night usa. But as wrote above, you need to take several shots to calibrate. Game have 640x228 resolution. Vampire Night USA

I also tried to calibrate the code veronica gun survivor, but I failed.

Comfarol commented 1 year ago

Vampire Night USA is 640x448

Are you using the calibration button you bound in the settings, it calibrates every shot for me.

I used yours but fine tuned it on my end and using

89.80 105.10 422 124 640 224

These values any good for you, does it improve your calibration issue?

The default values pcsx2 is using prob bad image

dante3732 commented 1 year ago

Vampire Night USA is 640x448

Yep, you right.

These values any good for you, does it improve your calibration issue?

Yep, you value fine, but my value little better for me. My value just points to the center of the circle in each corner, and yours shifts a little, but it not critical.

Comfarol commented 1 year ago

Someone will have to update it with the above values then, by default its loading those cooked values

IlDucci commented 1 year ago

Someone will have to update it with the above values then,

I can do that and add the other values I figured out. The thread is still valid until the issue with Dino Stalker is fixed.

dante3732 commented 1 year ago

I can do that and add the other values I figured out. The thread is still valid until the issue with Dino Stalker is fixed.

Dino Stalker PAL? USA work fine for me.

IlDucci commented 1 year ago

Dino Stalker PAL?

PAL, yes. See the first message.

Comfarol commented 1 year ago

Dino Stalker PAL has no default values

dante3732 commented 1 year ago

I tested 11 games. Time Crisis jap OK Time Crisis 2 usa OK Time Crisis 3 usa OK Crisis Zone usa OK, (If after calibration, the rifle can only fire single shots, in which case you need to repeat the calibration again until the rifle starts shooting properly.) Dino Stalker usa OK Resident Evil Dead usa OK Gunfighter II europe OK Endgame usa OK, but need plug guncon in usb 2

Virtua Cop pal BAD calibration work good, but there is a very long delay before the shot is fired Vampire Night usa BAD can't calibrate on default pcsx2 value (It fixed by custom) Resident Evil Gun Survivor 2 pal BAD the mouse cursor does not match the sight in calibration

Comfarol commented 1 year ago

Have you tried VC since update? It had bad values.

dante3732 commented 1 year ago

Have you tried VC since update? It had bad values.

Yep, i tested again now. Calibration good, but fire input lag too big, approximately 2 seconds.

Comfarol commented 1 year ago

I'm not getting any lag when firing on my end.

dante3732 commented 1 year ago

I'm not getting any lag when firing on my end.

After recalibrating in the main menu, there was no longer such a delay. Apparently there is still some kind of calibration problem.

IlDucci commented 1 year ago

I just realized that Dead Aim's settings were targeted to the PAL version, not the NTSC-U one. Anybody has Dead Aim on NTSC-U?

dante3732 commented 1 year ago

I just realized that Dead Aim's settings were targeted to the PAL version, not the NTSC-U one. Anybody has Dead Aim on NTSC-U?

Yep, USA work fine for me, but i use no interlacing patch.

IlDucci commented 1 year ago

Please test it with the values that I just uploaded here: https://github.com/PCSX2/pcsx2/pull/7636/files . And also make sure you have no patches enabled.

Comfarol commented 1 year ago

You doing Vampire Night USA values from above too?

IlDucci commented 1 year ago

Nope, those were the ones from before. I wasn't sure which one of the two sets were the final ones. Can you tell me?

Comfarol commented 1 year ago

89.80 105.10 422 124 640 224

Comfarol commented 1 year ago

The other games you guys are talking about i don't own so i cant help you there

IlDucci commented 1 year ago

My value just points to the center of the circle in each corner, and yours shifts a little, but it not critical.

What about that?

Comfarol commented 1 year ago

I dunno its perfect to me. he seems to be having issues so im biased :D Either is fine you talking a few pixels

dante3732 commented 1 year ago

Please test it with the values that I just uploaded here: https://github.com/PCSX2/pcsx2/pull/7636/files . And also make sure you have no patches enabled.

Looks fine.

IlDucci commented 1 year ago

I dunno its perfect to me. he seems to be having issues so im biased :D Either is fine you talking a few pixels

Try this (and let's hope GitHub doesn't pose any trouble): do a little video recording of the game on the calibration screen, with the mouse cursor being seen (OBS Studio should be best for this), after doing the calibration, but before leaving the calibration screen. Simply move the cursor to the center of the screen and then to the four corners, as close as you can to the screen limits.

Comfarol commented 1 year ago

its like two pixels between his/mine. im not making a video sorry, use his

IlDucci commented 1 year ago

its like two pixels between his/mine. im not making a video sorry, use his

Done.

Comfarol commented 1 year ago

Dino Stalker PAL works with values, its a little bit off on the edges if you want to fine tune. The FMV is so bad tho holy xD

image

dante3732 commented 1 year ago

The FMV is so bad tho holy xD

Just enable autosoftware for FMV.

Gun Survivor 2 Code Veronica PAL, I spent a lot of time and could not choose more precisely, you need to calibrate by trigger button. 2323

dante3732 commented 1 year ago

I captured input lag in veronica and virtua cop. The trigger is pulled when the screen flashes. And the shot happens in 2 seconds. This happens in 2 of the 11 tested games. https://drive.google.com/file/d/1XWx50MKMA3WV3JXPaPknlxMXqnXAs6wv/view?usp=share_link https://drive.google.com/file/d/1vp2YtPC-j-VLjiLXy401bPYW-gAeNjN-/view?usp=share_link

refractionpcsx2 commented 1 year ago

I don't think that's input lag, the input triggers the white screen, not the visual shot, the game does that. The white screen is a result of you pulling the trigger and the game flashing a white screen to find out where on the screen your "gun" is pointing, it then decides where you shot and does the shot effect.

legend800 commented 1 year ago

I only get the long black screen if I go way out the circle on cali (with default values). So there's still something funky here but it's not really impacting. I see you can get a lot of shots off fine when on the target.

Are you sure you calibration is saving? As I mentioned in the other thread, the steps are convoluted, but it works perfect for me if I do them.

Press Start, fire in center, fire offscreen, select Ok, with Press Start up, fire offscreen again. If you do that, you'll get this: 2022-12-20 09_37_15-Virtua Cop - Elite Edition Select Yes and go in-game

dante3732 commented 1 year ago

Press Start, fire in center, fire offscreen, select Ok, with Press Start up, fire offscreen again. If you do that, you'll get this:

Yep, i make same.

Comfarol commented 1 year ago

https://user-images.githubusercontent.com/27315987/208787578-1a6bb445-9e6a-45bd-a4ba-848aefa710bc.mp4

Don't press start. It seems if you press start then try calibrate you get the black screens and delays. If you just Calibrate and shoot off screen and pick yes its fine.

legend800 commented 1 year ago

If you don't press start, you're not calibrating. No matter where you shoot, the gun cursor does not change until you press Start. All your doing is bypassing it with those steps, which maybe fine for your setup. Maybe the cali screen is throwing things off for you. For me, it just breaks gameplay. I confirmed this by going in game and sure enough it's off-center like it was on cali screen here. 2022-12-20 18_31_56-Virtua Cop - Elite Edition

Please double check your iso is not patched, reg/ws cheats are disabled, check video/input settings, etc.. I had a similar issue on TC4 with missing gunshots on rpcs3 and it was only fixed by set fps cap to 30.

Comfarol commented 1 year ago

Mine isn't modded and I have no cheats. Only graphics setting i have is high blending and anti blur. Maybe yours is modded and has cheats?

When i start the game the cross hair is perfectly positioned with out calibrating, maybe that's why. What if you use custom settings to adjust it into position and not press start like what i do.

legend800 commented 1 year ago

I'm sure that'll work too. If the "auto" defaults line up my gun cursor with mouse cursor, then yeah, I can just skip all this stuff. That's ideal. But until the default does that, it's easier for me to go through the full cali steps vs. changing custom calibration settings, since I'm already using current values for Vampire Night. :)

Comfarol commented 1 year ago

Why do you need settings for Vampire Night, do the defaults also not work for you on that game too?

legend800 commented 1 year ago

Yeah, there was a bunch of conversation on this in the middle of the thread above. And only works with custom settings right now, until a new PR is cut.

Comfarol commented 1 year ago

Pretty sure its out? Mines working now with no custom settings.

Comfarol commented 1 year ago

Anyway with VC it seems the default values give different results for others for some reason? A per game GunCon 2 custom setting option would be the ideal way to get it accurate for individuals (and other games) until what ever is scuffing the calibration screen is found/fixed. It is scuffing because the JPN version calibrates with the same black screen with no prolonged blackness and delayed shooting.

legend800 commented 1 year ago

Pretty sure its out? Mines working now with no custom settings.

Ah, nice. Yep, Vampire Night (usa) is fixed now using automatic/default settings on the latest nightly.

dante3732 commented 1 year ago

Need replace value in Gunvari Collection + Time Crisis. This is a collection of games, it uses one calibration for menus, and the second for games. The current values are only suitable for the menu, but accurate calibration is not important there. So if you can't use 2 values one for games and second for the menu, then replace the current one on mine. 90,25 91 390,50 138,50 640 240

I figured out Virtua Cop, if the screen turns black after the shot and does not return to normal, then you need to repeat the calibration until it flashes once, then everything will work fine.

I also figured out the Time Crisis Crisis Zone, you need to press the calibration button until the screen stops flashing black (it flashes exactly the first time you press the calibration button, but stops after a couple of press), then the riffle will fire bursts without problems.

There was only a problem with Gun Survivor Code Veronica that I could not solve.

shanethmoore commented 1 year ago

I've noticed a lot of comments saying that Time Crisis 2 and 3 are perfect but I'm not so sure thats true. For single player calibration and gameplay it works fine but with split screen the calibration seems to be ignored and instead the cursor shots shows float outwards on the X and Y axis from p1 center screen or p2 center screen.

Unsure if it's calibration related or something else entirely. Could be worth mentioning here or https://github.com/PCSX2/pcsx2/issues/7619

I'd wager https://github.com/Comfarol/pcsx2/blob/e018c1ac06ed49fb3cc68be66f3f55f4ec67ce65/pcsx2/USB/usb-lightgun/guncon2.cpp#L79 needs to be updated based on whether the game is single or multi player.

legend800 commented 1 year ago

Good point. 2p was mentioned in the original PR that it would be added/supported in a feature commit.

FWIW, here's the values I used in nuvee plugin for either SP or MP for reference:

;time_crisis2 "Time Crisis 2 (U) - 2p" 95 45 390 150 namco 640 240

;time_crisis2 "Time Crisis 2 (U) - 1p" 120 97.5 390 154 namco 640 240

;time_crisis3 "Time Crisis 3 (U) - 2p" 95 45 390 150 namco 640 240

;time_crisis3 "Time Crisis 3 (U) - 1p" 120 97.5 390 154 namco 640 240