search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.72k stars 1.62k forks source link

[BUG]: Broken GFX in Juiced [SLES-53044] when using HW mode #7673

Closed Florinel787 closed 1 year ago

Florinel787 commented 1 year ago

Describe the Bug

When racing during any of the daytime settings (morning, afternoon, evening), the game gets overly bright and the prebaked road shadows disappear. image Additionally, lens flare/glare is broken and it manifests by: -missing effect on taillights and headlights -missing street lights but their lens flare is still visible image image Weirdly enough, the overbright issue is temporarily fixed by restarting the race and is brought back the moment you pause and unpause in game. Additionally, the game renders correctly (sans lens flare) when the race is paused (the pause menu is transparent by design and allows you to see the road and cars). image

Reproduction Steps

There are 3 ways of reproducing this bug:

  1. Simply running the game with default emulation and GS settings.
  2. Using HW rendering mode (Tested on Vulkan, DX11, DX12 and OpenGL):
    • Not using any manual HW fixes.
    • Trying to use manual HW fixes:
      • Enabling Auto Flush fixes overbright.
      • Enabling Preload Frame Data fixes lens flare but brings back overbright.
      • Any upscaling setting above native brings back overbright as well if not already using Preload Frame Data.
  3. Using SW rendering mode, set texture filtering to nearest.

Additional notes: This bug and these steps are also valid for the Steam Deck on SteamOS 3.3 and 3.4 as well as the Ryzen 7 4700U on Windows 10 64bit. I think it's safe to assume that this isssue isn't tied to any PC variables.

Expected Behavior

Using the SW renderer with default settings, we can get the correct image.

Screenshot of a day time race, with the brakes pressed: image

Screenshot of a night time race, with the brakes pressed and visible street lights: image image

PCSX2 Revision

Nightly v1.7.3777

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

i5-7400

GPU

RX 5600XT

GS Settings

Auto Flush and Preload Frame Data (from Hardware Fixes) are the only settings I've been fiddling around with. image image

Emulation Settings

No response

GS Window Screenshots

Just stretching the image to 16:9 and disabling Anti-Blur image

Logs & Dumps

No response

refractionpcsx2 commented 1 year ago

Can you provide a GS Dump from a point where the problem occurs please?

You can find this by going to Tools->Single Frame GS Dump, then zip up the two files it puts in your /snaps folder.

Florinel787 commented 1 year ago

Juiced GS Dump1.zip Dump taken with default emulation settings, on the first arcade race of the game, with the brakes on so it includes both overbright and lens flare issues

refractionpcsx2 commented 1 year ago

Thanks for that. Does the problem also appear in software mode? if not can you also take a GS Dump in software mode? It looks like it might be a GS Download/Readback issue if software is okay, which sucks, they are more of a pain to diagnose.

Florinel787 commented 1 year ago

juiced gs dump2.zip

Yes, Software is indeed okay when using default settings image

The SW dump was taken under the same circumstances (same race, brakes pressed, same exact other settings) as the previous one

refractionpcsx2 commented 1 year ago

awesome :) Thanks!

Florinel787 commented 1 year ago

Thank you, too, for your dedication to solve these issues. It's unfortunate that the diagnosis is going to be a pain. I hope it turns out to be an easy fix :D Happy holidays!

Florinel787 commented 1 year ago

I'm sorry if this is necroposting, but I've made an additional discovery related to the overbright bug. It seems that, after restarting a race (which I've said in the initial post that it temporarily fixes the overbright issue), a lot of stress is lifted off the EE. I've noticed this when I was experimenting around on my Steam Deck with default emulation and GS settings. As a side note, the Steam Deck suffers of EE starvation when the overbright bug is occurring and I was shocked when I saw the performance greatly improve after restarting the race. I was no longer needing to enable mild moderate cycle skipping!

I'll be providing a GS HW dump of that same first arcade race after having restarted it. I don't know why I haven't thought of providing a dump like this in the first place, my bad.

juiced gs dump3.zip

Since I'd last posted on this thread, I've upgraded to windows 11 on my desktop and steam os 3.4.2 on my steam deck, but I don't think there is any influence on that.

Florinel787 commented 1 year ago

The gameDB fixes have improved gameplay A LOT and I can't thank you enough for your effort, but there are still some problems that need fixing. Firstly, the daytime lens flare on taillights is still weak (in comparison to SW mode) or even missing. Secondly, the weird performance issue is still present. (The one that is fixed by restarting the race but unfixed by pausing and unpausing the same race afterwards). I'm attaching 4 dumps in the following order: lens flare issue, pre-restart performance, post-restart performance and post-unpause performance

(late edit) lens flare dump also includes tail lights

Juiced_SLES-53044_20230505184712.gs.zip

Juiced_SLES-53044_20230505184824.gs.zip

Juiced_SLES-53044_20230505184837.gs.zip

Juiced_SLES-53044_20230505184845.gs.zip

refractionpcsx2 commented 1 year ago

can you try it in native resolution to see if the lens flare and tail lights are ok?

Also can you make a dump for the tail lights?

Florinel787 commented 1 year ago

this was all in native resolution... (edit) and the first dump is for the tail lights (edit 2) should have made it clearer in the previous post, my bad